From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id EB51B1FF137 for ; Tue, 17 Feb 2026 11:00:52 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8F1BE31EBF; Tue, 17 Feb 2026 11:01:43 +0100 (CET) Message-ID: Date: Tue, 17 Feb 2026 11:01:09 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 proxmox-backup 12/18] client: don't poll terminated source in FixedChunkStream To: Robert Obkircher , pbs-devel@lists.proxmox.com References: <20260210150642.469670-1-r.obkircher@proxmox.com> <20260210150642.469670-13-r.obkircher@proxmox.com> Content-Language: en-US, de-DE From: Christian Ebner In-Reply-To: <20260210150642.469670-13-r.obkircher@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1771322463091 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.047 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: UR6W7JPW2PA3UCMNVJGFAHDCSOW6PORY X-Message-ID-Hash: UR6W7JPW2PA3UCMNVJGFAHDCSOW6PORY X-MailFrom: c.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 2/10/26 4:06 PM, Robert Obkircher wrote: > Fix incorrect chunking when the input file is a pts character device > (stdin in an interactive terminal). Previously, the stream could > produce multiple smaller chunks from interactive input, and a single > Ctrl+D was not enough to terminate it. This was because a None from > the source resulted in Some partial chunk, but the next time the input > was polled again and it suddenly had more input. > > The documentation of Stream::poll_next clearly states that calling it > on a terminated stream may panic, block forever, or cause other kinds > of problems, so this should be fixed even it it appeared to work with > normal files. > > Using the fuse method or adding a FusedStream trait bound might be > nicer that seemed like a larger change compared to the boolean. > > Signed-off-by: Robert Obkircher Good catch! Same issue is however also present for the dynamic ChunkStream, so the safeguard should be added for it as well! That can however be done as followup patch if nothing else comes up for these patches.