Re: [PATCH qemu-server 3/5] drive: read actual size when cloning TPM drive

[Fiona Ebner <f.ebner@proxmox.com>]

The commit subject should start with "clone disk:"

Am 19.10.26 um 11:53 AM schrieb Thomas Ellmenreich:
> When cloning a TPM drive, don't assume the default size of 4MiB, instead
> read and then use the actual size. The default size is constant, but can
> be changed, if the granularity of the backing storage is bigger than 4MiB.

Style nit: line too long.

> 
> This allows TPM storages larger than 4MiB be moved to different storages

Replace "TPM storages larger than" with "TPM volumes on storages with a
granularity larger than".

> without producing an error.
> 
> Suggested-by: Fiona Ebner <f.ebner@proxmox.com>
> Signed-off-by: Thomas Ellmenreich <t.ellmenreich@proxmox.com>

Reviewed-by: Fiona Ebner <f.ebner@proxmox.com>

> ---
>  src/PVE/QemuServer.pm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/PVE/QemuServer.pm b/src/PVE/QemuServer.pm
> index 89192e9f..c93fd4c5 100644
> --- a/src/PVE/QemuServer.pm
> +++ b/src/PVE/QemuServer.pm
> @@ -7876,7 +7876,7 @@ sub clone_disk {
>          } elsif ($dst_drivename eq 'efidisk0') {
>              $size = $efisize or die "internal error - need to specify EFI disk size\n";
>          } elsif ($dst_drivename eq 'tpmstate0') {
> -            $size = PVE::QemuServer::Drive::TPMSTATE_DISK_SIZE;
> +            $size = get_tpmstate_size($drive->{file}, $storecfg);
>          } else {
>              clone_disk_check_io_uring(
>                  $vmid, $drive, $storecfg, $src_storeid, $storeid, $use_drive_mirror,