From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id E81461FF13F for ; Fri, 27 Mar 2026 00:16:27 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B53461E7F2; Fri, 27 Mar 2026 00:16:50 +0100 (CET) Message-ID: Date: Fri, 27 Mar 2026 00:16:16 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: applied: [PATCH qemu-server v2 0/4] rework fs-freeze agent property From: Thomas Lamprecht To: pve-devel@lists.proxmox.com References: <20260325213415.3861690-1-t.lamprecht@proxmox.com> Content-Language: en-US In-Reply-To: <20260325213415.3861690-1-t.lamprecht@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1774566927044 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.009 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: XIRZ4UEHU62LHU7B7HMAVGXK22CO5OB4 X-Message-ID-Hash: XIRZ4UEHU62LHU7B7HMAVGXK22CO5OB4 X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Am 25.03.26 um 22:34 schrieb Thomas Lamprecht: > Sorry for the quick v2 submission, forgot to stage a hunk to complete > the final patch and applied some of Fiona's patches [0] already so a > rebase was required anyway. > > Somewhat RFC, albeit I'm pretty sure about this the more I think about > it, even though the transition cost is naturally not great. > > Very likely clashes with Fiona's recent QGA-skip-freeze-if-frozen series > [0], but started this already a few days around and figured it might > still be relevant in the current form. > > I probably would squash in the deprecation of the intermediate > guest-fsfreeze variant with the commit making the long-time > freeze-fs-on-backup property an alias to the new variant, which would > be named 'freeze-fs' hereafter. > > Changes v1 -> v2: > - rebase on master > - apply hunk to change guest-fsfreeze to freeze-fs in should_fs_freeze > too in patch 4/4. > > Thomas Lamprecht (4): > agent: add should_fs_freeze helper > agent: treat freeze-fs-on-backup as alias for guest-fsfreeze > tests: cfg2cmd: add agent guest-fsfreeze config tests > qga: rename guest-fsfreeze to freeze-fs > > src/PVE/API2/Qemu.pm | 10 +++--- > src/PVE/QemuConfig.pm | 5 ++- > src/PVE/QemuServer/Agent.pm | 35 ++++++++++++++----- > src/PVE/VZDump/QemuServer.pm | 6 +--- > .../cfg2cmd/qga-fs-freeze-backup-legacy.conf | 2 ++ > .../qga-fs-freeze-backup-legacy.conf.cmd | 29 +++++++++++++++ > src/test/cfg2cmd/qga-fs-freeze.conf | 2 ++ > src/test/cfg2cmd/qga-fs-freeze.conf.cmd | 29 +++++++++++++++ > src/test/cfg2cmd/qga-minimal.conf | 2 ++ > src/test/cfg2cmd/qga-minimal.conf.cmd | 29 +++++++++++++++ > 10 files changed, 126 insertions(+), 23 deletions(-) > create mode 100644 src/test/cfg2cmd/qga-fs-freeze-backup-legacy.conf > create mode 100644 src/test/cfg2cmd/qga-fs-freeze-backup-legacy.conf.cmd > create mode 100644 src/test/cfg2cmd/qga-fs-freeze.conf > create mode 100644 src/test/cfg2cmd/qga-fs-freeze.conf.cmd > create mode 100644 src/test/cfg2cmd/qga-minimal.conf > create mode 100644 src/test/cfg2cmd/qga-minimal.conf.cmd > applied with Fiona's findings and nits addressed and R-b added