From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 35C0C1FF15E for ; Mon, 10 Nov 2025 09:59:21 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6763010370; Mon, 10 Nov 2025 10:00:06 +0100 (CET) Message-ID: Date: Mon, 10 Nov 2025 10:00:03 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Proxmox Backup Server development discussion , Hannes Laimer References: <20251107132329.42965-1-h.laimer@proxmox.com> <20251107132329.42965-7-h.laimer@proxmox.com> Content-Language: en-US, de-DE From: Christian Ebner In-Reply-To: <20251107132329.42965-7-h.laimer@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1762765181582 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.048 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox-backup v2 3/3] ui: traffic-control: add users field in edit form and list X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" Reviewed-by: Christian Ebner On 11/7/25 2:23 PM, Hannes Laimer wrote: > Signed-off-by: Hannes Laimer > --- > www/config/TrafficControlView.js | 7 +++++++ > www/window/TrafficControlEdit.js | 18 ++++++++++++++++++ > 2 files changed, 25 insertions(+) > > diff --git a/www/config/TrafficControlView.js b/www/config/TrafficControlView.js > index 0b22d29a..5cfec82b 100644 > --- a/www/config/TrafficControlView.js > +++ b/www/config/TrafficControlView.js > @@ -181,6 +181,13 @@ Ext.define('PBS.config.TrafficControlView', { > renderer: 'render_bandwidth', > dataIndex: 'burst-out', > }, > + { > + header: gettext('Users'), > + flex: 3, > + sortable: true, > + renderer: (users) => (users ? Ext.String.htmlEncode(users.join(', ')) : ''), > + dataIndex: 'users', > + }, > { > header: gettext('Networks'), > flex: 3, > diff --git a/www/window/TrafficControlEdit.js b/www/window/TrafficControlEdit.js > index 0bbbf363..2063c107 100644 > --- a/www/window/TrafficControlEdit.js > +++ b/www/window/TrafficControlEdit.js > @@ -215,6 +215,7 @@ Ext.define('PBS.window.TrafficControlEdit', { > PBS.Utils.delete_if_default(values, 'rate-out'); > PBS.Utils.delete_if_default(values, 'burst-in'); > PBS.Utils.delete_if_default(values, 'burst-out'); > + PBS.Utils.delete_if_default(values, 'users'); > if (typeof values.delete === 'string') { > values.delete = values.delete.split(','); > } > @@ -276,6 +277,23 @@ Ext.define('PBS.window.TrafficControlEdit', { > ], > > columnB: [ > + { > + xtype: 'pmxUserSelector', > + fieldLabel: gettext('Users'), > + name: 'users', > + multiSelect: true, > + allowBlank: true, > + cbind: { > + deleteEmpty: '{!isCreate}', > + }, > + emptyText: gettext('Applies to all users'), > + autoEl: { > + tag: 'div', > + 'data-qtip': gettext( > + 'Limit applies only to authenticated requests by these users. Overrides IP-only rules when both match. If networks are specified on this rule as well, it\'ll only apply if the users request comes from one of the specified networks.', > + ), > + }, > + }, > { > xtype: 'proxmoxtextfield', > fieldLabel: gettext('Network(s)'), _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel