From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 3FA211FF191 for ; Tue, 7 Oct 2025 12:49:53 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id AE70B16189; Tue, 7 Oct 2025 12:49:55 +0200 (CEST) Message-ID: Date: Tue, 7 Oct 2025 12:49:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta To: Nicolas Frey , Proxmox VE development discussion References: <20251006133308.119141-1-n.frey@proxmox.com> <20251006133308.119141-2-n.frey@proxmox.com> <77926145-fad2-4ff4-8da4-97341a29d1b1@proxmox.com> Content-Language: en-US From: Thomas Lamprecht In-Reply-To: X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1759834162891 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.025 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH pve-manager v3 1/1] ui: fix #6209: create snapshots and backups from context menu X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Am 07.10.25 um 12:34 schrieb Nicolas Frey: > I used some variations of added network throttle using chrome dev > tools and traffic control and noticed that the disabling of the button > is starting to get really noticable in the 1-1.5 second range (if you > don't have sniper level mouse accuracy). Anything below that is > negotiable, but if the request stalls even a bit above that range it > could become an annoyance (e.g. being just about too early and having > to click a second time or simply the long wait). Though similarly, you > still have to wait for the window to appear if you clicked it in the > new version, and there may also be an error if snapshots aren't > supported on the guest. Thanks for checking so closely and reporting back! > As a note, the original implementation (v1/v2) matches the behaviour > found in the Snapshots tab, which has the button disabled until > querying snapshot features is complete. This also shows that the > `current guest does not support taking new snapshots` until fully > loaded. IMO parity between them is essential, as to not have two > different approaches which might confuse users. > > I cannot tell which approach is better here, but it might be a sign > that Shannon had also suggested the other way... Yeah, that, and this being basically pre-existing behavior in the Snapshots tab, like you mentioned, is probably enough weight to tip the scale towards your original approach. Thanks for trying this out though, sometimes some experimentation is needed, and even though it's only a small UX thing, these things tend to get copied and thus leak often quite fast in other parts of the UI or even UIs for our other projects, so it can be worth to look more closely once in a while here. _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel