From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 241031FF13B for ; Wed, 03 Jun 2026 12:45:23 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id BCC3280A0; Wed, 3 Jun 2026 12:45:22 +0200 (CEST) Message-ID: Date: Wed, 3 Jun 2026 12:45:17 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH proxmox 4/5] pbs-api-types: add WriteNonExpanding datastore operation To: Robert Obkircher , pbs-devel@lists.proxmox.com References: <20260602130001.217482-1-r.obkircher@proxmox.com> <20260602130001.217482-5-r.obkircher@proxmox.com> Content-Language: en-US, de-DE From: Christian Ebner In-Reply-To: <20260602130001.217482-5-r.obkircher@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1780483481317 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.069 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [maintenance.rs] Message-ID-Hash: 27LL25FOFDZC6JXKHIIH45ZEYSXOAY4U X-Message-ID-Hash: 27LL25FOFDZC6JXKHIIH45ZEYSXOAY4U X-MailFrom: c.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 6/2/26 3:00 PM, Robert Obkircher wrote: > The new variant will be used for Write operations that should be > allowed in a new GarbageCollection maintenace mode. This name was > chosen over "Prune" because it might also make sense to allow other > administrative tasks that do not actually delete things. > > Signed-off-by: Robert Obkircher Reviewed-by: Christian Ebner > --- > pbs-api-types/src/maintenance.rs | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/pbs-api-types/src/maintenance.rs b/pbs-api-types/src/maintenance.rs > index 7e9599be..2d11aff2 100644 > --- a/pbs-api-types/src/maintenance.rs > +++ b/pbs-api-types/src/maintenance.rs > @@ -25,14 +25,16 @@ pub const MAINTENANCE_MESSAGE_SCHEMA: Schema = > pub enum Operation { > /// for any read operation like backup restore or RRD metric collection > Read, > - /// for any write/delete operation, like backup create or GC > + /// for any read/write/delete operation, like backup create > Write, > + /// for read/write/delete operations that reduce or maintain > + /// storage usage, like GC or prune. > + WriteNonExpanding, > /// for any purely logical operation on the in-memory state of the datastore, e.g., to check if > /// some mutex could be locked (e.g., GC already running?) > /// > /// NOTE: one must *not* do any IO operations when only helding this Op state > Lookup, > - // GarbageCollect or Delete? > } > > #[api] > @@ -105,7 +107,7 @@ impl MaintenanceMode { > (MaintenanceType::Offline, _) => bail!("offline maintenance mode: {message}"), > (MaintenanceType::S3Refresh, _) => bail!("S3 refresh maintenance mode: {message}"), > (MaintenanceType::ReadOnly, Operation::Read) => Ok(()), > - (MaintenanceType::ReadOnly, Operation::Write) => { > + (MaintenanceType::ReadOnly, Operation::Write | Operation::WriteNonExpanding) => { > bail!("read-only maintenance mode: {message}") > } > #[cfg(feature = "enum-fallback")]