From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <t.lamprecht@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by lists.proxmox.com (Postfix) with ESMTPS id 79D146B4A6
 for <pve-devel@lists.proxmox.com>; Thu, 10 Dec 2020 20:10:07 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
 by firstgate.proxmox.com (Proxmox) with ESMTP id 6A1AC195CE
 for <pve-devel@lists.proxmox.com>; Thu, 10 Dec 2020 20:09:37 +0100 (CET)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
 [212.186.127.180])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by firstgate.proxmox.com (Proxmox) with ESMTPS id C11D7195BE
 for <pve-devel@lists.proxmox.com>; Thu, 10 Dec 2020 20:09:36 +0100 (CET)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
 by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 87FC344F89
 for <pve-devel@lists.proxmox.com>; Thu, 10 Dec 2020 20:09:36 +0100 (CET)
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
 Dylan Whyte <d.whyte@proxmox.com>
References: <20201126092912.28245-1-d.whyte@proxmox.com>
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
Message-ID: <b20c236d-ec0a-cfcd-7c56-d38314586022@proxmox.com>
Date: Thu, 10 Dec 2020 20:09:14 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:84.0) Gecko/20100101
 Thunderbird/84.0
MIME-Version: 1.0
In-Reply-To: <20201126092912.28245-1-d.whyte@proxmox.com>
Content-Type: text/plain; charset=UTF-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-SPAM-LEVEL: Spam detection results:  0
 AWL -0.068 Adjusted score from AWL reputation of From: address
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 NICE_REPLY_A           -0.001 Looks like a legit reply (A)
 RCVD_IN_DNSWL_MED        -2.3 Sender listed at https://www.dnswl.org/,
 medium trust
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pve-devel] [PATCH pve-installer] installer: minor language
 fixup
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Thu, 10 Dec 2020 19:10:07 -0000

On 26.11.20 10:29, Dylan Whyte wrote:
> just some nitpicky changes.
> 
> Signed-off-by: Dylan Whyte <d.whyte@proxmox.com>
> ---
>  html-common/tags    |  1 +
>  html-pbs/page1.htm  |  2 +-
>  html-pbs/tags       |  1 +
>  html-pve/page1.htm  |  8 ++++----
>  html-pve/passwd.htm | 10 +++++-----
>  html-pve/tags       |  1 +
>  6 files changed, 13 insertions(+), 10 deletions(-)
>  create mode 100644 html-common/tags
>  create mode 100644 html-pbs/tags
>  create mode 100644 html-pve/tags

what are those new "tags" files? from your IDE? They do not seem right to me.

> 
> diff --git a/html-common/tags b/html-common/tags
> new file mode 100644
> index 0000000..408de88
> --- /dev/null
> +++ b/html-common/tags
> @@ -0,0 +1 @@
> +!_TAG_FILE_SORTED	2	/0=unsorted, 1=sorted, 2=foldcase/
> diff --git a/html-pbs/page1.htm b/html-pbs/page1.htm
> index debfdf1..353f780 100644
> --- a/html-pbs/page1.htm
> +++ b/html-pbs/page1.htm
> @@ -30,7 +30,7 @@
>        <tbody><tr>
>          <td valign="top" width="30"><img src="plus.png"></td>
>          <td valign="top"><b>Please verify the installation target</b><br>
> -          The displayed hard disk is used for installation.
> +          The displayed hard disk will be used for the installation.
>            <br>Warning: All existing partitions and data will be lost.
>            <br><br>
>          </td>
> diff --git a/html-pbs/tags b/html-pbs/tags
> new file mode 100644
> index 0000000..408de88
> --- /dev/null
> +++ b/html-pbs/tags
> @@ -0,0 +1 @@
> +!_TAG_FILE_SORTED	2	/0=unsorted, 1=sorted, 2=foldcase/
> diff --git a/html-pve/page1.htm b/html-pve/page1.htm
> index d76cc8a..0ad0898 100644
> --- a/html-pve/page1.htm
> +++ b/html-pve/page1.htm
> @@ -17,10 +17,10 @@
>      <table>
>        <tbody><tr><td><b>The Proxmox Installer</b>
>  	automatically partitions your hard disk. It installs all required
> -	packages and finally makes the system bootable from hard disk.
> +	packages and makes the system bootable from the hard disk.
>  	All existing partitions and data will be lost.
>  	<br><br>
> -	Press the Next button to continue installation.
> +	Press the Next button to continue the installation.
>        </td></tr>
>      </tbody></table>
>    </p></td>
> @@ -30,7 +30,7 @@
>        <tbody><tr>
>  	<td valign="top" width="30"><img src="plus.png"></td>
>  	<td valign="top"><b>Please verify the installation target</b><br>
> -	  The displayed hard disk is used for installation.
> +	  The displayed hard disk will be used for the installation.
>  	  <br>Warning: All existing partitions and data will be lost.
>  	  <br><br>
>  	</td>
> @@ -46,7 +46,7 @@
>  	<td valign="top" width="30"><img src="plus.png"></td>
>  	<td valign="top" width="560"><b>Graphical user interface</b><br>
>  	  Final configuration will be done on the graphical user
> -	  interface via a web browser.
> +	  interface, via a web browser.
>  	  <br><br>
>  	</td>
>        </tr>
> diff --git a/html-pve/passwd.htm b/html-pve/passwd.htm
> index b1a8522..1c7d2fc 100644
> --- a/html-pve/passwd.htm
> +++ b/html-pve/passwd.htm
> @@ -16,9 +16,9 @@
>      <td colspan="2" valign="top" width="400"><br><p>
>      <table>
>        <tr><td><b>Proxmox Virtual Environment</b> is a
> -	full featured highly secure GNU/Linux system based on Debian.
> +	full featured, highly secure GNU/Linux system, based on Debian.
>  	<br><br>
> -        Please provide the <i>root</i> password in this step.
> +        In this step, please provide the <i>root</i> password.
>        </td></tr>
>      </table>
>    </p></td>
> @@ -27,8 +27,8 @@
>        <tr>
>  	<td valign="top" width="30"><img src="plus.png"></td>
>  	<td valign="top"><b>Password:</b>
> -	  Please use a strong password. It should have 8 or more characters.
> -	  Also combine letters, numbers, and symbols.
> +	  Please use a strong password. It should be at least 8 characters long,
> +	  and contain a combination of letters, numbers, and symbols.
>  	  <br><br>
>  	</td>
>        </tr>
> @@ -43,7 +43,7 @@
>        </tr>
>        <tr>
>  	<td valign="top" width="30"></td>
> -	<td valign="top">Press the Next button to continue installation.</td>
> +	<td valign="top">Press the Next button to continue the installation.</td>
>        </tr>
>      </table>
>    </p></td>
> diff --git a/html-pve/tags b/html-pve/tags
> new file mode 100644
> index 0000000..408de88
> --- /dev/null
> +++ b/html-pve/tags
> @@ -0,0 +1 @@
> +!_TAG_FILE_SORTED	2	/0=unsorted, 1=sorted, 2=foldcase/
>