From: Filip Schauer <f.schauer@proxmox.com>
To: Dominik Csapak <d.csapak@proxmox.com>, pve-devel@lists.proxmox.com
Subject: Re: [PATCH pve-xtermjs 0/3] xterm.js: fix obstructed start button
Date: Mon, 7 Sep 2026 10:42:35 +0200 [thread overview]
Message-ID: <b167ecfe-320a-4feb-8f79-caccc96cd07b@proxmox.com> (raw)
In-Reply-To: <20260902074338.914500-1-d.csapak@proxmox.com>
On 02/09/2026 09:43, Dominik Csapak wrote:
> The first two patches are just formatting cleanup to make development
> easier when using proxmox-biome as LSP and the third patch is the actual
> fix.
>
> Not sure how this was broken, I tested this with old chrome/firefox
> versions and our older xterm.js packages and could still reproduce. Then
> tested on a PVE 8.4 install and it also happened. (Though with older
> xterm.js releases it was not as noticable since the default
> background-color changed in the last few releases)
>
> So my current guess is that either something unrelated changed which
> has an influence on this (desktop environments, etc.) or this was simply
> broken since a long time.
Can confirm that xterm.js is no longer displayed on a stopped container,
which fixes the start button obstruction on consoles with a small
height.
Tested-by: Filip Schauer <f.schauer@proxmox.com>
prev parent reply other threads:[~2026-09-07 8:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-02 7:40 [PATCH pve-xtermjs 0/3] xterm.js: fix obstructed start button Dominik Csapak
2026-09-02 7:40 ` [PATCH pve-xtermjs 1/3] xterm.js: add tidy make target Dominik Csapak
2026-09-02 7:40 ` [PATCH pve-xtermjs 2/3] xterm.js: run make tidy Dominik Csapak
2026-09-02 7:40 ` [PATCH pve-xtermjs 3/3] xterm.js: fix obstructed start button Dominik Csapak
2026-09-07 8:42 ` Filip Schauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b167ecfe-320a-4feb-8f79-caccc96cd07b@proxmox.com \
--to=f.schauer@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.