Re: [PATCH proxmox-backup v6 11/15] server: pull: prefix log messages and add error context

[Thomas Lamprecht <t.lamprecht@proxmox.com>]

Am 20.04.26 um 13:55 schrieb Fabian Grünbichler:
> should we pad the labels? the buffered logger knows all currently active
> labels and could adapt it? otherwise especially for host backups the
> logs are again not really scannable by humans, because there will be
> weird jumps in alignment.. or (.. continued below)

IMO it might be better to keep these simple and plain and rather do any
"touching up" on the frontend UI side when rendering such a log.
For now that would need to be a parser for some specific task-log types
to make them aware of the format, which is naturally not that great, in
the mid/long term it might be much nicer to have some structured logging
available for task logs, as then we could encode more info that a task log
render could either render nicer or also allow filtering on.

Am 20.04.26 um 13:55 schrieb Fabian Grünbichler:
> the way the prefix and snapshot are formatted could also be interpreted
> at first glance as a timestamp of the log line.. why not just prepend
> the prefix on the logger side, and leave it up to the caller to do the
> formatting? then we could us "{type}/{id}/" as prefix here? or add
> 'snapshot' in those lines to make it clear? granted, this is more of an
> issue when viewing the log via `proxmox-backup-manager`, as in the UI we
> have the log timestamps up front..

ah, my comment above is partially overlapping with this part of the
reply. And I'd also always prefix the time upfront, IMO a bit odd if
it's in the "middle". But more importantly, I'd not sweat the details
here that much and would rather target staying closer with pre-existing
format (to avoid going back-and-forth), we can still improve on that later.