From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <l.wagner@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by lists.proxmox.com (Postfix) with ESMTPS id E1D8C9C6BE
for <pbs-devel@lists.proxmox.com>; Tue, 24 Oct 2023 14:20:55 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id BCE451FF3F
for <pbs-devel@lists.proxmox.com>; Tue, 24 Oct 2023 14:20:25 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
[94.136.29.106])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by firstgate.proxmox.com (Proxmox) with ESMTPS
for <pbs-devel@lists.proxmox.com>; Tue, 24 Oct 2023 14:20:25 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 00F6844B50
for <pbs-devel@lists.proxmox.com>; Tue, 24 Oct 2023 14:20:25 +0200 (CEST)
Message-ID: <b0e48ab1-7d31-49cb-b133-bb618ab0e493@proxmox.com>
Date: Tue, 24 Oct 2023 14:20:24 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Content-Language: de-AT, en-US
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>, Philipp Hufnagl <p.hufnagl@proxmox.com>
References: <20231023154302.2558918-1-p.hufnagl@proxmox.com>
<20231023154302.2558918-3-p.hufnagl@proxmox.com>
From: Lukas Wagner <l.wagner@proxmox.com>
In-Reply-To: <20231023154302.2558918-3-p.hufnagl@proxmox.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-SPAM-LEVEL: Spam detection results: 0
AWL -0.022 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: Re: [pbs-devel] [PATCH proxmox-backup 2/3] ui: Show if Filter
includes or excludes
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
<pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Tue, 24 Oct 2023 12:20:55 -0000
On 10/23/23 17:43, Philipp Hufnagl wrote:
> @@ -163,8 +183,12 @@ Ext.define('PBS.form.GroupFilter', {
>
> let filter = [];
> me.lookup('grid').getStore().each((rec) => {
> - if (rec.data.type && rec.data.input) {
> - filter.push(`${rec.data.type}:${rec.data.input}`);
> + if (rec.data.type && rec.data.input && rec.data.behaviour) {
> + let behaviour_string = '';
> + if (rec.data.behaviour === 'exclude') {
> + behaviour_string = 'exclude:';
^
should be in camelCase, according to our JS Style guide
> + }
> + filter.push(`${behaviour_string}${rec.data.type}:${rec.data.input}`);
> }
> });
>
--
- Lukas