From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <t.lamprecht@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by lists.proxmox.com (Postfix) with ESMTPS id 5DCFA9655C
 for <pve-devel@lists.proxmox.com>; Tue, 24 Jan 2023 16:29:06 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
 by firstgate.proxmox.com (Proxmox) with ESMTP id 334A55EF9
 for <pve-devel@lists.proxmox.com>; Tue, 24 Jan 2023 16:28:36 +0100 (CET)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
 [94.136.29.106])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by firstgate.proxmox.com (Proxmox) with ESMTPS
 for <pve-devel@lists.proxmox.com>; Tue, 24 Jan 2023 16:28:35 +0100 (CET)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
 by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 08E1B45EC4
 for <pve-devel@lists.proxmox.com>; Tue, 24 Jan 2023 16:28:35 +0100 (CET)
Message-ID: <b00f4b14-47cb-5c2b-c811-256be1216bd0@proxmox.com>
Date: Tue, 24 Jan 2023 16:28:33 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:109.0) Gecko/20100101
 Thunderbird/109.0
Content-Language: en-GB
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
 Lukas Wagner <l.wagner@proxmox.com>
References: <20230123131735.400368-1-l.wagner@proxmox.com>
 <20230123131735.400368-3-l.wagner@proxmox.com>
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
In-Reply-To: <20230123131735.400368-3-l.wagner@proxmox.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.531 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 NICE_REPLY_A           -1.148 Looks like a legit reply (A)
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pve-devel] [PATCH v2 manager] ui: backup: replication: replace
 non-clickable checkbox with icons
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Tue, 24 Jan 2023 15:29:06 -0000

Am 23/01/2023 um 14:17 schrieb Lukas Wagner:
> From a usability view, having a checkbox that is not clickable is pretty
> misleading, especially if the visual style is exactly the same as in
> other places in the UI where the checkbox is functional.
> 
> Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
> ---
>  www/manager6/dc/Backup.js        | 11 ++++++-----
>  www/manager6/grid/Replication.js | 11 +++++++----
>  2 files changed, 13 insertions(+), 9 deletions(-)
> 
> diff --git a/www/manager6/dc/Backup.js b/www/manager6/dc/Backup.js
> index 9d305984..8a306330 100644
> --- a/www/manager6/dc/Backup.js
> +++ b/www/manager6/dc/Backup.js
> @@ -784,12 +784,13 @@ Ext.define('PVE.dc.BackupView', {
>  		{
>  		    header: gettext('Enabled'),
>  		    width: 80,
> -		    dataIndex: 'enabled',
> -		    xtype: 'checkcolumn',
> +		    dataindex: 'enabled',

you break setting dataIndex by writing it all lowercase ?!

> +		    align: 'center',
> +		    renderer: function(enabled, cell, record) {
> +			return Proxmox.Utils.render_enabled_icon(record.data.enabled);
> +		    },


with data index fixed, this could be:


renderer: Proxmox.Utils.renderEnabledIcon,

Or if you really want to avoid passing the remaining params to the renderer:

renderer: enabled => Proxmox.Utils.renderEnabledIcon(enabled),

but normally that's really not a problem for renders.

>  		    sortable: true,
> -		    disabled: true,
> -		    disabledCls: 'x-item-enabled',
> -		    stopSelection: false,
> +
>  		},
>  		{
>  		    header: gettext('ID'),
> diff --git a/www/manager6/grid/Replication.js b/www/manager6/grid/Replication.js
> index b17288b9..261c2755 100644
> --- a/www/manager6/grid/Replication.js
> +++ b/www/manager6/grid/Replication.js
> @@ -279,11 +279,14 @@ Ext.define('PVE.grid.ReplicaView', {
>  
>  	me.columns = [
>  	    {
> -		text: gettext('Enabled'),
> -		dataIndex: 'enabled',
> -		xtype: 'checkcolumn',
> +		header: gettext('Enabled'),
> +		width: 80,
> +		dataindex: 'enabled',

same here w.r.t. breaking dataIndex

> +		align: 'center',
> +		renderer: function(enabled, cell, record) {
> +		    return Proxmox.Utils.render_enabled_icon(record.data.enabled);
> +		},

same here w.r.t. shorter direct renderer

>  		sortable: true,
> -		disabled: true,
>  	    },
>  	    {
>  		text: 'ID',