From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id B67231FF137 for ; Tue, 31 Mar 2026 10:18:30 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 83A3B12DD1; Tue, 31 Mar 2026 10:18:57 +0200 (CEST) Date: Tue, 31 Mar 2026 10:18:52 +0200 From: Gabriel Goller To: Robin Christ Subject: Re: [PATCH ifupdown2 4/4] bridge: Fix multiple Single VXLAN Devices in bridge not having tunnel_info applied on first run Message-ID: Mail-Followup-To: Robin Christ , pve-devel@lists.proxmox.com, Robin Christ , Christoph Heiss References: <20260330213921.533853-1-robin@rchrist.io> <20260330213921.533853-5-robin@rchrist.io> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260330213921.533853-5-robin@rchrist.io> User-Agent: NeoMutt/20241002-35-39f9a6 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1774945077626 X-SPAM-LEVEL: Spam detection results: 0 AWL -1.477 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 1 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 1 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 1 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: XTXYTLTB3VT2BJUMBEICNX2G2TC2KSAW X-Message-ID-Hash: XTXYTLTB3VT2BJUMBEICNX2G2TC2KSAW X-MailFrom: g.goller@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: pve-devel@lists.proxmox.com, Robin Christ X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 30.03.2026 23:39, Robin Christ wrote: > From: Robin Christ > > If you add multiple Single VXLAN Devices to a bridge, only the last one would get the proper > tunnel_info applied, ultimately resulting in a non-functional network setup. > This could be fixed by a second execution of ifupdown2. > > The reason for this was that the original code was not written with multiple Single VXLAN Devices > in a single bridge in mind, thus it had only the variable single_vxlan_device_ifaceobj storing > a single interface that would control the application of tunnel_info the bridge's SVDs. > Replacing the variable against a list single_vxlan_device_ifaceobjs and adding another little > loop fixes the issue. > > Additionally, some very exhaustive, clarifying information has been added > > Signed-off-by: Robin Christ > --- > ...tiple-single-vxlan-devices-in-bridge.patch | 101 ++++++++++++++++++ > debian/patches/series | 1 + > 2 files changed, 102 insertions(+) > create mode 100644 debian/patches/pve/0019-bridge-fix-multiple-single-vxlan-devices-in-bridge.patch Thanks for these patches! If you haven't already, please sign the contribution agreement and send it to office@proxmox.com (https://pve.proxmox.com/wiki/Developer_Documentation#Software_License_and_Copyright). The dry-run patches before look good, maybe @Christoph can have a look at them as well. About this one though: what is the use-case? we don't use SVDs and so the tunnel_info property is also not used AFAIK?