From: Gabriel Goller <g.goller@proxmox.com>
To: Christoph Heiss <c.heiss@proxmox.com>
Cc: pbs-devel@lists.proxmox.com
Subject: Re: [PATCH proxmox v2 2/3] fix #6121: network-api: config: add support for `bond-miimon` option
Date: Tue, 10 Nov 2026 11:58:39 +0100 [thread overview]
Message-ID: <avL4euU6K4DG0qdo@luna.proxmox.com> (raw)
In-Reply-To: <7eef50e6-66b2-4eba-8a3c-410f308aa963@proxmox.com>
On 10.11.2026 11:13, Christoph Heiss wrote:
> Thanks for taking a look!
>
> On 11/9/26 15:57, Gabriel Goller wrote:
> > On 09.11.2026 15:28, Christoph Heiss wrote:
> >> Fixes #6121 [0].
> >>
> >> Adds support for the 'bond-miimon' option to the ifupdown(2) config
> >> writer and parser.
> >>
> >> The option is always written out for bonds, with a default value of 100
> >> - much like PVE does it.
> >
> > Umm I understand this but what about the bond-arp-interval (arp-mode). These
> > properties are mutually exclusive...
>
> Interesting note. AFAICS we don't allow configuring that property
> through our stack anywhere yet, i.e. neither PVE nor PBS/PDM (didn't
> look at PMG specifically, but I assume it's the same there).
Hmm yeah thats a reason for leaving it out...
> > Maybe we should allow the user to configure arp mode as well?
>
> We could possibly implement that separately in the future, if arp-mode
> is something regularly needed/set by users. But this is rather
> tangentially to this series IMO.
Haven't looked at the code, if this is something that can be added easily then
it's fine with me.
I think the arp mode is used quite seldomly anyway..
Maybe @Stefan can add something here?
next prev parent reply other threads:[~2026-11-10 10:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-09 14:28 [PATCH proxmox{,-backup} v2 0/3] fix #6121: add 'bond-miimon' option for network interfaces Christoph Heiss
2026-11-09 14:28 ` [PATCH proxmox v2 1/3] fix #6121: network-api: api: add `bond-miimon` option for interfaces Christoph Heiss
2026-11-09 14:28 ` [PATCH proxmox v2 2/3] fix #6121: network-api: config: add support for `bond-miimon` option Christoph Heiss
2026-11-09 14:57 ` Gabriel Goller
2026-11-10 10:13 ` Christoph Heiss
2026-11-10 10:58 ` Gabriel Goller [this message]
2026-11-09 14:28 ` [PATCH proxmox-backup v2 3/3] api: network: reuse interface create/update methods from network-api Christoph Heiss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avL4euU6K4DG0qdo@luna.proxmox.com \
--to=g.goller@proxmox.com \
--cc=c.heiss@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.