From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 27B2B1FF0C0 for ; Wed, 18 Nov 2026 17:55:23 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id C8675217C8; Wed, 18 Nov 2026 17:55:20 +0100 (CET) Date: Wed, 18 Nov 2026 17:55:15 +0100 From: Gabriel Goller To: Stefan Hanreich Subject: Re: [PATCH proxmox-ve-rs v3 03/32] sdn: add zone references to OSPF and BGP fabrics Message-ID: References: <20261116161154.343743-1-g.goller@proxmox.com> <20261116161154.343743-4-g.goller@proxmox.com> <35afc43c-c3a7-4ce0-8f22-b0c9f4c16742@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <35afc43c-c3a7-4ce0-8f22-b0c9f4c16742@proxmox.com> User-Agent: NeoMutt/20260616 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1795020916450 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.089 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) POISEN_SPAM_PILL 0.1 Meta: its spam POISEN_SPAM_PILL_1 0.1 random spam to be learned in bayes POISEN_SPAM_PILL_3 0.1 random spam to be learned in bayes RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 7J7O2PWACW26JRBMPGOTTSUFXTAV5YE2 X-Message-ID-Hash: 7J7O2PWACW26JRBMPGOTTSUFXTAV5YE2 X-MailFrom: g.goller@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: pve-devel@lists.proxmox.com X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 18.11.2026 15:10, Stefan Hanreich wrote: > Is there a reason why updating / deleting a zone is implemented here, but > rejected in pve-network? Afaict deleting a zone actually works from the > API as the checks there are insufficient? Can we just add #[updater(skip)] > here and remove zone from the deletable properties? Doesn't work because `zone` is not in the deletable properties: root@node1:~# pvesh set /cluster/sdn/fabrics/fabric/test --protocol ospf --delete zone 400 Parameter verification failed. delete[0]: value 'zone' does not have a value in the enumeration 'area, redistribute, route_filter' pvesh set --protocol [OPTIONS] [FORMAT_OPTIONS] Either way removed the unused rust updater stuff. This was a leftover from the previous version. Thanks for the review!