From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 8D4871FF0C0 for ; Wed, 18 Nov 2026 16:41:46 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id E8D42217CA; Wed, 18 Nov 2026 16:41:43 +0100 (CET) Date: Wed, 18 Nov 2026 16:41:38 +0100 From: Gabriel Goller To: Stefan Hanreich Subject: Re: [PATCH pve-common v3 01/32] interfaces: preserve VRF membership across address family changes Message-ID: References: <20261116161154.343743-1-g.goller@proxmox.com> <20261116161154.343743-2-g.goller@proxmox.com> <50a15a4d-a6f5-49df-92dc-21534d83fdb3@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <50a15a4d-a6f5-49df-92dc-21534d83fdb3@proxmox.com> User-Agent: NeoMutt/20260504 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1795016499071 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.242 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: TQ4BKTNQCGVJT7UJAMA3BECH3L7ZF4TA X-Message-ID-Hash: TQ4BKTNQCGVJT7UJAMA3BECH3L7ZF4TA X-MailFrom: g.goller@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: pve-devel@lists.proxmox.com X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 18.11.2026 15:13, Stefan Hanreich wrote: > Can we additionally deny VRF for all OVS types for now? Done here in pve-common. > We should also check if an interface is part of a fabric? Also makes sense, done in pve-network on the api endpoint. We need to read/parse the fabric config for this but oh well :( > [snip] Thanks for the review!