Re: [PATCH ifupdown2] fix #8117: backport upstream fix for unavailable bond slaves

[Gabriel Goller <g.goller@proxmox.com>]

On 15.10.2026 16:43, Christoph Heiss wrote:
> Thanks for tackling this!
> 
> On 10/8/26 12:23, Gabriel Goller wrote:
> > A missing slave at boot can abort bond setup before available slaves are
> > enslaved, leaving the bond broken. Backport upstream PR #355 to continue
> > setup after single slave failures.
> > 
> > Upstream-Link: https://github.com/CumulusNetworks/ifupdown2/pull/355
> > Fixes: https://bugzilla.proxmox.com/show_bug.cgi?id=8117
> > 
> > Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
> 
> Tested this with a similar setup to [0], just with `bond-slaves` set to:
> 
>   bond-slaves doesnotexist enp6s20.1 enp6s21.1
> 
> Please consider this:
> 
> Tested-by: Christoph Heiss <c.heiss@proxmox.com>
> 
> [0]
> https://lore.proxmox.com/pve-devel/DM5AYOQZLL1E.2J6DHNGY4O0N4@proxmox.com/
> 
> [..]
> 
> > +diff --git a/tests/unit/test_bond.py b/tests/unit/test_bond.py
> > +new file mode 100644
> > +index 00000000..01fab468
> > +--- /dev/null
> > ++++ b/tests/unit/test_bond.py
> > +@@ -0,0 +1,103 @@
> > ++"""Bond regression tests; run with python3 -m unittest discover -s tests/unit."""
> 
> These tests don't run when doing a `make deb` with our (downstream)
> packaging:
> 
>   dh_auto_test -O--buildsystem=pybuild
>   I: pybuild base:311: cd
> [..]ifupdown2/ifupdown2-3.3.0-1+pmx12/.pybuild/cpython3_3.13_ifupdown2/build;
> python3.13 -m unittest discover -v
> 
>   ----------------------------------------------------------------------
>   Ran 0 tests in 0.000s
> 
>   NO TESTS RAN
> 
> IMO would make sense to have them run on a `make deb` too.

Hmm good catch, didn't run the tests :/

This should be fixed with something like:

 diff --git a/debian/rules b/debian/rules
 index cc9547dce6..0443852924 100755
 --- a/debian/rules
 +++ b/debian/rules
 @@ -3,6 +3,7 @@
  #export DH_VERBOSE=1
  export PYBUILD_NAME=ifupdown2
  export PYBUILD_INSTALL_ARGS=--install-lib=/usr/share/ --install-scripts=/usr/share/
 +export PYBUILD_TEST_ARGS=--start-directory {dir}/tests/unit
 
  %:
  	dh $@ --with=python3 --buildsystem=pybuild

I'll send a patch.

Thanks for the review!