all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Gabriel Goller <g.goller@proxmox.com>
To: Luke Yasuda <jing@jing.rocks>
Cc: pve-devel@lists.proxmox.com
Subject: Re: [PATCH proxmox-ve-rs] proxmox-frr: add missing build-deps proxmox-frr-templates
Date: Mon, 5 Oct 2026 10:56:55 +0200	[thread overview]
Message-ID: <asNmISypyouHGxr_@luna.proxmox.com> (raw)
In-Reply-To: <20261004101741.902857-2-jing@jing.rocks>

On 04.10.2026 19:11, Luke Yasuda wrote:
> It fails on tests without proxmox-frr-templates.
> 
> Signed-off-by: Luke Yasuda <jing@jing.rocks>
> ---
> I have to admit that I don't know much about rust or rust packaging...
> But congratulations on migrating from mailman2 to mailman3! Although
> I can't find where is the mailing list archive. I'm not subscribed to
> this list.
> ---
>  proxmox-frr/debian/control       | 3 ++-
>  proxmox-frr/debian/debcargo.toml | 1 +
>  2 files changed, 3 insertions(+), 1 deletion(-)

LGTM, what do you think @Fabian?

> diff --git a/proxmox-frr/debian/control b/proxmox-frr/debian/control
> index b118bec..1436baf 100644
> --- a/proxmox-frr/debian/control
> +++ b/proxmox-frr/debian/control
> @@ -19,7 +19,8 @@ Build-Depends-Arch: cargo:native <!nocheck>,
>   librust-serde-1+derive-dev <!nocheck>,
>   librust-serde-repr-0.1+default-dev <!nocheck>,
>   librust-thiserror-2+default-dev <!nocheck>,
> - librust-tracing-0.1+default-dev <!nocheck>
> + librust-tracing-0.1+default-dev <!nocheck>,
> + proxmox-frr-templates <!nocheck>,
>  Maintainer: Proxmox Support Team <support@proxmox.com>
>  Standards-Version: 4.7.2
>  Vcs-Git: git://git.proxmox.com/git/proxmox-ve-rs.git
> diff --git a/proxmox-frr/debian/debcargo.toml b/proxmox-frr/debian/debcargo.toml
> index 87a787e..d427d2c 100644
> --- a/proxmox-frr/debian/debcargo.toml
> +++ b/proxmox-frr/debian/debcargo.toml
> @@ -5,3 +5,4 @@ maintainer = "Proxmox Support Team <support@proxmox.com>"
>  [source]
>  vcs_git = "git://git.proxmox.com/git/proxmox-ve-rs.git"
>  vcs_browser = "https://git.proxmox.com/?p=proxmox-ve-rs.git"
> +build_depends = ["proxmox-frr-templates"]
> -- 
> 2.55.0
> 
> 
> 
> 
> 




  reply	other threads:[~2026-10-05  8:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-04 10:11 [PATCH proxmox-ve-rs] proxmox-frr: add missing build-deps proxmox-frr-templates Luke Yasuda
2026-10-05  8:56 ` Gabriel Goller [this message]
2026-10-05 11:05 ` applied: " Fabian Grünbichler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=asNmISypyouHGxr_@luna.proxmox.com \
    --to=g.goller@proxmox.com \
    --cc=jing@jing.rocks \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal