From: Gabriel Goller <g.goller@proxmox.com>
To: Hannes Laimer <h.laimer@proxmox.com>
Cc: pve-devel@lists.proxmox.com
Subject: Re: [PATCH pve-network] sdn: ipam: fix dual-stack per-MAC lookup in the PVE plugin
Date: Wed, 26 Aug 2026 11:25:06 +0200 [thread overview]
Message-ID: <ao6w07Q4DLi7y2Pf@luna.proxmox.com> (raw)
In-Reply-To: <20260824134244.1066515-1-h.laimer@proxmox.com>
On 24.08.2026 15:42, Hannes Laimer wrote:
> The subnet loop skipped every remaining subnet once a v6 address was
> found, dropping a v4 record living in a later subnet. Which subnet comes
> first is hash order, so in a dual-stack zone the v4 half of the answer
> went missing at random. The intended v4 short-circuit never fired
> either, since subnet keys are CIDR strings and ip_is_ipv4 returns false
> for those.
>
> Skip a subnet only when its own family is already answered.
>
> Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
LGTM.
Reviewed-by: Gabriel Goller <g.goller@proxmox.com>
> ---
> src/PVE/Network/SDN/Ipams/PVEPlugin.pm | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
next prev parent reply other threads:[~2026-08-26 9:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-24 13:42 [PATCH pve-network] sdn: ipam: fix dual-stack per-MAC lookup in the PVE plugin Hannes Laimer
2026-08-26 9:25 ` Gabriel Goller [this message]
2026-08-26 10:18 ` applied: " Fiona Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ao6w07Q4DLi7y2Pf@luna.proxmox.com \
--to=g.goller@proxmox.com \
--cc=h.laimer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.