From: Gabriel Goller <g.goller@proxmox.com>
To: Hannes Laimer <h.laimer@proxmox.com>
Cc: pve-devel@lists.proxmox.com
Subject: Re: [PATCH pve-manager 2/2] ui: sdn: ipam: allow picking the nic instead of typing its MAC
Date: Wed, 26 Aug 2026 11:58:02 +0200 [thread overview]
Message-ID: <ao62l4d5bPVfG-W0@luna.proxmox.com> (raw)
In-Reply-To: <20260819124407.856577-3-h.laimer@proxmox.com>
On 19.08.2026 14:44, Hannes Laimer wrote:
> Instead of hand-copying a MAC from the guest's hardware panel, take a
> guest and one of its NICs on the assignments's VNet, and fill the MAC in
> from there.
>
> Setting a MAC without a guest stays possible, so this is purely a UX
> improvement. We could also restrict this, so our IPAM only manages IPs
> of guests in our SDN.
>
> Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
> ---
When selecting a vm and one of its nics, the mac address is filled in correctly
but is not sent to the api. This creates an entry without a mac address, which
cannot be deleted.
The rest LGTM.
> www/manager6/sdn/IpamEdit.js | 112 ++++++++++++++++++++++++++++++++++-
> 1 file changed, 109 insertions(+), 3 deletions(-)
next prev parent reply other threads:[~2026-08-26 9:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-19 12:44 [PATCH manager/network 0/2] sdn: add guest/nic selectors to IPAM create window Hannes Laimer
2026-08-19 12:44 ` [PATCH pve-network 1/2] api: sdn: ipam: add optional vmid to POST endpoint Hannes Laimer
2026-08-19 12:44 ` [PATCH pve-manager 2/2] ui: sdn: ipam: allow picking the nic instead of typing its MAC Hannes Laimer
2026-08-26 9:58 ` Gabriel Goller [this message]
2026-08-26 11:14 ` superseded: [PATCH manager/network 0/2] sdn: add guest/nic selectors to IPAM create window Hannes Laimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ao62l4d5bPVfG-W0@luna.proxmox.com \
--to=g.goller@proxmox.com \
--cc=h.laimer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.