From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <t.lamprecht@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
(No client certificate requested)
by lists.proxmox.com (Postfix) with ESMTPS id 71507643A4
for <pbs-devel@lists.proxmox.com>; Tue, 6 Oct 2020 13:10:21 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 6223025020
for <pbs-devel@lists.proxmox.com>; Tue, 6 Oct 2020 13:10:21 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
[212.186.127.180])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
(No client certificate requested)
by firstgate.proxmox.com (Proxmox) with ESMTPS id 4116F25013
for <pbs-devel@lists.proxmox.com>; Tue, 6 Oct 2020 13:10:20 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 0CA3B4550A
for <pbs-devel@lists.proxmox.com>; Tue, 6 Oct 2020 13:10:20 +0200 (CEST)
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>, Dominik Csapak <d.csapak@proxmox.com>
References: <20201006102528.15383-1-d.csapak@proxmox.com>
<20201006102528.15383-5-d.csapak@proxmox.com>
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
Message-ID: <af43c0a6-2938-a697-ecdb-f62b915119b2@proxmox.com>
Date: Tue, 6 Oct 2020 13:10:19 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:82.0) Gecko/20100101
Thunderbird/82.0
MIME-Version: 1.0
In-Reply-To: <20201006102528.15383-5-d.csapak@proxmox.com>
Content-Type: text/plain; charset=UTF-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
X-SPAM-LEVEL: Spam detection results: 0
AWL -0.146 Adjusted score from AWL reputation of From: address
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
NICE_REPLY_A -0.001 Looks like a legit reply (A)
RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/,
medium trust
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: Re: [pbs-devel] [PATCH proxmox-backup v2 5/6] ui:
Dashboard/TaskSummary: add Verifies to the Summary
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
<pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Tue, 06 Oct 2020 11:10:21 -0000
On 06.10.20 12:25, Dominik Csapak wrote:
> and count every type that starts with 'verify' (e.g. verifyjob)
>=20
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> www/Dashboard.js | 6 ++++++
> www/dashboard/TaskSummary.js | 1 +
> 2 files changed, 7 insertions(+)
>=20
I have some weird stuff going on here, namely, I get tasks with the same =
upid
multiple times in the store??
This screws up the counts, e.g., verifies are counted all double, gc are=
also
more (but here not doubled!)
I.e., if I apply the below diff I get different numbers, now matching wit=
h the
actual task list which opens when clicking on such a summary number..
diff --git a/www/Dashboard.js b/www/Dashboard.js
index 1a68029f..0597194b 100644
--- a/www/Dashboard.js
+++ b/www/Dashboard.js
@@ -150,7 +150,12 @@ Ext.define('PBS.Dashboard', {
verify: { error: 0, warning: 0, ok: 0 },
};
+ let upid_seen =3D {};
records.forEach(record =3D> {
+ if (upid_seen[record.data.upid]) {
+ return;
+ }
+ upid_seen[record.data.upid] =3D 1;
let type =3D record.data.worker_type;
if (type =3D=3D=3D 'syncjob') {
type =3D 'sync';