From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <t.lamprecht@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 81AFF74998 for <pve-devel@lists.proxmox.com>; Wed, 2 Jun 2021 14:17:32 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6E1BFAD7D for <pve-devel@lists.proxmox.com>; Wed, 2 Jun 2021 14:17:32 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id BBEA4AD6D for <pve-devel@lists.proxmox.com>; Wed, 2 Jun 2021 14:17:27 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 8632C466F1 for <pve-devel@lists.proxmox.com>; Wed, 2 Jun 2021 14:17:27 +0200 (CEST) Message-ID: <aedb7e3f-01d5-8492-4221-3f8bac3923b7@proxmox.com> Date: Wed, 2 Jun 2021 14:17:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:89.0) Gecko/20100101 Thunderbird/89.0 Content-Language: en-US To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>, Fabian Ebner <f.ebner@proxmox.com> References: <20210423101501.27300-1-f.ebner@proxmox.com> From: Thomas Lamprecht <t.lamprecht@proxmox.com> In-Reply-To: <20210423101501.27300-1-f.ebner@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.018 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [diskmanage.pm, disks.pm] Subject: [pve-devel] applied-partially: [PATCH-SERIES storage/widget-toolkit/manager] Add wipe disk api call and button X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Wed, 02 Jun 2021 12:17:32 -0000 On 23.04.21 12:14, Fabian Ebner wrote: > so admins wipe disks that are not actually used, but contain left-overs. > > The last patch needs dependency bumps for pve-storage and > proxmox-widget-toolkit. > > storage: > > Fabian Ebner (5): > diskmanage: add wipe_blockdev method > diskmanage: factor out mounted_blockdevs helper > diskmanage: add is_mounted method > diskmanage: add has_holder method > api: add wipedisk call > > PVE/API2/Disks.pm | 42 ++++++++++++++++++++++ > PVE/Diskmanage.pm | 91 ++++++++++++++++++++++++++++++++++++++++++++--- > 2 files changed, 129 insertions(+), 4 deletions(-) > applied the storage part, with a followup to add the single partitions to the wipefs command to ensure that really all FS signatures are gone, else, if one creates a similar partition layout later a mkfs. call may complain about potential existing FS.