From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <t.lamprecht@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 4667373561 for <pve-devel@lists.proxmox.com>; Tue, 6 Jul 2021 12:45:41 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3388D8CAE for <pve-devel@lists.proxmox.com>; Tue, 6 Jul 2021 12:45:11 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 8B2B78C6F for <pve-devel@lists.proxmox.com>; Tue, 6 Jul 2021 12:45:10 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 602CF40D62; Tue, 6 Jul 2021 12:45:10 +0200 (CEST) Message-ID: <add902f4-a247-d98d-6632-80c67ef2bcb0@proxmox.com> Date: Tue, 6 Jul 2021 12:44:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:90.0) Gecko/20100101 Thunderbird/90.0 Content-Language: en-US To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>, Alexandre Derumier <aderumier@odiso.com> References: <20210705220230.518658-1-aderumier@odiso.com> From: Thomas Lamprecht <t.lamprecht@proxmox.com> In-Reply-To: <20210705220230.518658-1-aderumier@odiso.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.513 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com, qemu.pm] Subject: [pve-devel] applied: [PATCH qemu-server] api2: fix vmconfig_apply_pending errors handling X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Tue, 06 Jul 2021 10:45:41 -0000 On 06.07.21 00:02, Alexandre Derumier wrote: > commit > https://git.proxmox.com/?p=qemu-server.git;a=commit;h=eb5e482ded9ae6aeb6575de9441b79b90a5de531 > > have introduced error handling for offline pending apply, > > - PVE::QemuServer::vmconfig_apply_pending($vmid, $conf, $storecfg, $running); > + PVE::QemuServer::vmconfig_apply_pending($vmid, $conf, $storecfg, $running, $errors); > > sub vmconfig_apply_pending { > - my ($vmid, $conf, $storecfg) = @_; > + my ($vmid, $conf, $storecfg, $errors) = @_; > > but they was wrong nonused $running param, so currently $errors are not correctly handled > > Signed-off-by: Alexandre Derumier <aderumier@odiso.com> > --- > PVE/API2/Qemu.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > applied, with Oguz T-b, thanks!