From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <t.lamprecht@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by lists.proxmox.com (Postfix) with ESMTPS id 63DEF61B2C
for <pbs-devel@lists.proxmox.com>; Thu, 10 Feb 2022 12:07:07 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 518AA1C158
for <pbs-devel@lists.proxmox.com>; Thu, 10 Feb 2022 12:06:37 +0100 (CET)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
[94.136.29.106])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by firstgate.proxmox.com (Proxmox) with ESMTPS id C6B191C13B
for <pbs-devel@lists.proxmox.com>; Thu, 10 Feb 2022 12:06:36 +0100 (CET)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 97ACA46DC0
for <pbs-devel@lists.proxmox.com>; Thu, 10 Feb 2022 12:06:36 +0100 (CET)
Message-ID: <ad23618d-110c-bf2a-d73f-1dcf2cd258cd@proxmox.com>
Date: Thu, 10 Feb 2022 12:06:35 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:97.0) Gecko/20100101
Thunderbird/97.0
Content-Language: en-US
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>, Matthias Heiserer <m.heiserer@proxmox.com>
References: <20220210101632.1736415-1-m.heiserer@proxmox.com>
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
In-Reply-To: <20220210101632.1736415-1-m.heiserer@proxmox.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.059 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
NICE_REPLY_A -0.001 Looks like a legit reply (A)
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
T_SCC_BODY_TEXT_LINE -0.01 -
Subject: Re: [pbs-devel] [PATCH proxmox-backup] node config: display default
language
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
<pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Thu, 10 Feb 2022 11:07:07 -0000
On 10.02.22 11:16, Matthias Heiserer wrote:
> The default-langage can now be reset by selecting 'Default (English)'.
>
this seems to be on top of your not yet applied patch? That should be
mentioned, but actually it would be even nicer if you coukd squash
that into the old one?
For futher series it'd be also great if you could mark revisions as such,
i.e., using git format-patchs' `-vN`, e.g., `-v2` in this case - thx!
> Signed-off-by: Matthias Heiserer <m.heiserer@proxmox.com>
> ---
for such small series its pretty clear, but it still can make sense to
note that this (soft-)depends on a bumped proxmox-widget-toolkit in this
"meta area" here.
> www/config/NodeOptionView.js | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/www/config/NodeOptionView.js b/www/config/NodeOptionView.js
> index 24458058..506768d9 100644
> --- a/www/config/NodeOptionView.js
> +++ b/www/config/NodeOptionView.js
> @@ -46,11 +46,10 @@ Ext.define('PBS.NodeOptionView', {
> xtype: 'combobox',
> name: 'default-lang',
> text: gettext('Default language'),
> - defaultValue: 'English',
> - // skip the 'default' item. It's not possible to delete the default
> - // language from the GUI, but setting it to 'en' has the same result
> - comboItems: Proxmox.Utils.language_array().slice(1),
> + defaultValue: '__default__',
> + comboItems: Proxmox.Utils.language_array(),
> deleteEmpty: true,
> + renderer: Proxmox.Utils.render_language,
> },
> ],
>
looks OK change wise, once squashed:
Reviewed-by: Thomas Lamprecht <t.lamprecht@proxmox.com>