From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <t.lamprecht@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 0216D6B67E for <pve-devel@lists.proxmox.com>; Tue, 26 Jan 2021 18:44:00 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id EBB471B0ED for <pve-devel@lists.proxmox.com>; Tue, 26 Jan 2021 18:43:29 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 859F41B0E0 for <pve-devel@lists.proxmox.com>; Tue, 26 Jan 2021 18:43:29 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 4FBEC46116 for <pve-devel@lists.proxmox.com>; Tue, 26 Jan 2021 18:43:29 +0100 (CET) To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>, Dominik Csapak <d.csapak@proxmox.com> References: <20210120123204.11176-1-d.csapak@proxmox.com> From: Thomas Lamprecht <t.lamprecht@proxmox.com> Message-ID: <ac676d1a-5a1c-35bf-c76f-49d2df5e9f2d@proxmox.com> Date: Tue, 26 Jan 2021 18:43:28 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:85.0) Gecko/20100101 Thunderbird/85.0 MIME-Version: 1.0 In-Reply-To: <20210120123204.11176-1-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.067 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [qemuserver.pm, qemu.pm] Subject: [pve-devel] applied: [PATCH qemu-server v3] fix #2788: do not resume vms after backup if they were paused before X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Tue, 26 Jan 2021 17:44:00 -0000 On 20.01.21 13:32, Dominik Csapak wrote: > by checking if the vm is paused at the beginning and skipping the resume > now we also skip the qga freeze/thaw (which cannot work if the vm is > paused) > > moved the 'vm_is_paused' sub from the api to PVE/QemuServer.pm so it is > available everywhere we need it. > > since a suspend backup would pause the vm anyway, we can skip that step > also > > Signed-off-by: Dominik Csapak <d.csapak@proxmox.com> > --- > changes to v2: > * actually include code changes (git add is not optional), sry for the noise > > PVE/API2/Qemu.pm | 14 ++------------ > PVE/QemuServer.pm | 10 ++++++++++ > PVE/VZDump/QemuServer.pm | 11 +++++++++-- > 3 files changed, 21 insertions(+), 14 deletions(-) > > applied, with Fabi's T-b, thanks! Not sure if it'd be really worth it to do the backup-init lock proposed in a thread reply here though..