From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 5FF421FF09B for ; Mon, 31 Aug 2026 13:32:25 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 995E620954; Mon, 31 Aug 2026 13:32:24 +0200 (CEST) Message-ID: Date: Mon, 31 Aug 2026 13:32:19 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH manager v3 00/13] ui: split out disks and nics into grids To: pve-devel@lists.proxmox.com, Dominik Csapak References: <20260515085349.1123127-1-d.csapak@proxmox.com> <8a6db5dc-701b-4e41-b749-0d30e152365f@proxmox.com> Content-Language: en-US From: Jonas Theisen In-Reply-To: <8a6db5dc-701b-4e41-b749-0d30e152365f@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1788175926285 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.762 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 36PA2FTUUM5X5OSBK2DUBIV65M36QAQX X-Message-ID-Hash: 36PA2FTUUM5X5OSBK2DUBIV65M36QAQX X-MailFrom: j.theisen@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 8/31/26 11:23, Dominik Csapak wrote: > ping, any feedback on this? https://lore.proxmox.com/pve-devel/20260227091158.715596-1-d.csapak@proxmox.com/ On 2/27/26 10:05, Dominik Csapak wrote: > This is done to improve visibility of configuration of disks and nics. > Currently only the raw property string is shown in the UI, which leads > to bad UX when having many options configured and especially when having > pending changes in these situations because it's hard to parse visually. > > The disks and nics are shown below the main options, each as their own > grids with relevant columns. By default all columns that can be edited > in the gui are shown (with the exception of the bandwidth limits, since > they're not often used and blow up the number of columns). All other > options from the config are there but hidden by default. > > As a fallback, in case there are new options not yet in the ui, a 'Raw > Config' column was added, which contains the raw porperty string again > (but it's hidden by default). In theory this change sounds sensible but currently patch 07/13 does not apply for me. If there is a new version i'd be happy to test and give feedback.