From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id B1F2C1FF183 for ; Wed, 19 Nov 2025 15:18:43 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id AA520E5EE; Wed, 19 Nov 2025 15:18:47 +0100 (CET) Message-ID: Date: Wed, 19 Nov 2025 15:18:13 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Markus Frank To: Proxmox VE development discussion , Fiona Ebner References: <20251117162819.465530-1-m.frank@proxmox.com> <20251117162819.465530-2-m.frank@proxmox.com> <1e5dc1f7-539f-46c3-b79b-de186a3ea89d@proxmox.com> <0bec9cbe-7247-4b04-9fb8-e1c5f0886aa2@proxmox.com> Content-Language: en-US In-Reply-To: <0bec9cbe-7247-4b04-9fb8-e1c5f0886aa2@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1763561862641 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.001 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH qemu-server v1 1/3] vga: allow live-migration with clipboard X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On 2025-11-17 17:43, Fiona Ebner wrote: > Am 17.11.25 um 5:41 PM schrieb Fiona Ebner: >> Am 17.11.25 um 5:28 PM schrieb Markus Frank: >>> The live-migration feature now works with qemu's upstream commit: >>> 5d56bff11e ("ui/vdagent: add migration support") >>> >>> Signed-off-by: Markus Frank >>> --- >>> src/PVE/API2/Qemu.pm | 5 ----- >>> src/PVE/QemuMigrate.pm | 5 ----- >>> src/PVE/QemuServer.pm | 2 +- >>> 3 files changed, 1 insertion(+), 11 deletions(-) >>> >>> diff --git a/src/PVE/API2/Qemu.pm b/src/PVE/API2/Qemu.pm >>> index 02f5caec..314b6a48 100644 >>> --- a/src/PVE/API2/Qemu.pm >>> +++ b/src/PVE/API2/Qemu.pm >>> @@ -5267,11 +5267,6 @@ __PACKAGE__->register_method({ >>> my ($local_resources, $mapped_resources, $missing_mappings_by_node) = >>> PVE::QemuMigrate::Helpers::check_local_resources($vmconf, $res->{running}, 1); >>> >>> - my $vga = PVE::QemuServer::parse_vga($vmconf->{vga}); >>> - if ($res->{running} && $vga->{'clipboard'} && $vga->{'clipboard'} eq 'vnc') { >>> - push $local_resources->@*, "clipboard=vnc"; >>> - } >> >> I suppose this depends on having machine version >= 10.1, or? (In any >> case QEMU binary version >= 10.1 but that is implied by machine version >= 10.1) Yes, it needs QEMU version >= 10.1. However, when I set the machine version to < 10.1 (tested with version 6.2), the migration still works fine and the clipboard still functions on the other node. It seems that the machine version is unrelated here. I suppose it would be better to check the QEMU version using get_running_qemu_version, wouldn't it? _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel