From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <d.csapak@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by lists.proxmox.com (Postfix) with ESMTPS id 83796A776
for <pbs-devel@lists.proxmox.com>; Tue, 27 Jun 2023 13:29:26 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 6CB5035128
for <pbs-devel@lists.proxmox.com>; Tue, 27 Jun 2023 13:29:26 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
[94.136.29.106])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by firstgate.proxmox.com (Proxmox) with ESMTPS
for <pbs-devel@lists.proxmox.com>; Tue, 27 Jun 2023 13:29:24 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
by proxmox-new.maurer-it.com (Proxmox) with ESMTP id A408F45245;
Tue, 27 Jun 2023 13:29:24 +0200 (CEST)
Message-ID: <aa1d24fb-a8d5-d753-0d7d-409b15b404e4@proxmox.com>
Date: Tue, 27 Jun 2023 13:29:23 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Content-Language: en-US
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>, Lukas Wagner <l.wagner@proxmox.com>
References: <20230627100452.328303-1-l.wagner@proxmox.com>
<20230627100452.328303-2-l.wagner@proxmox.com>
From: Dominik Csapak <d.csapak@proxmox.com>
In-Reply-To: <20230627100452.328303-2-l.wagner@proxmox.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.016 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
T_SCC_BODY_TEXT_LINE -0.01 -
URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See
http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more
information. [proxmox.com]
Subject: Re: [pbs-devel] [PATCH proxmox-backup 2/2] ui: fix refresh after
TFA unlock
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
<pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Tue, 27 Jun 2023 11:29:26 -0000
while it does work, the correct way to fix this is to add the column dataindex
to the model definition, since that is what the diffstore uses to update it's
data on a load
i sent a fix for that, which is intended to be applied instead of this patch:
https://lists.proxmox.com/pipermail/pbs-devel/2023-June/006244.html
On 6/27/23 12:04, Lukas Wagner wrote:
> Problem was that refresh after unlock did not work properly.
> Also calling load on the outer store seems to fix it, but I'm
> not sure why. Judging from the code in `DiffStore.js`, the
> outer store seems be subscribed to the `load` event from `rstore`,
> performing a load itself if the event occurs.
>
> Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
> ---
> www/config/UserView.js | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/www/config/UserView.js b/www/config/UserView.js
> index 9a0a0b2b..168af902 100644
> --- a/www/config/UserView.js
> +++ b/www/config/UserView.js
> @@ -95,7 +95,10 @@ Ext.define('PBS.config.UserView', {
> return Ext.String.htmlEncode(userid.match(/^(.+)@([^@]+)$/)[2]);
> },
>
> - reload: function() { this.getView().getStore().rstore.load(); },
> + reload: function() {
> + this.getView().getStore().rstore.load();
> + this.getView().getStore().load();
> + },
>
> init: function(view) {
> Proxmox.Utils.monStoreErrors(view, view.getStore().rstore);