From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <t.lamprecht@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 881977FF94 for <pve-devel@lists.proxmox.com>; Tue, 16 Nov 2021 07:35:29 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 747A71308B for <pve-devel@lists.proxmox.com>; Tue, 16 Nov 2021 07:34:59 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id AF9521307D for <pve-devel@lists.proxmox.com>; Tue, 16 Nov 2021 07:34:58 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 7AF3543808 for <pve-devel@lists.proxmox.com>; Tue, 16 Nov 2021 07:34:58 +0100 (CET) Message-ID: <a90044f3-7f30-224c-ef78-24e9c1b0e759@proxmox.com> Date: Tue, 16 Nov 2021 07:34:57 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:95.0) Gecko/20100101 Thunderbird/95.0 Content-Language: en-US To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>, Stoiko Ivanov <s.ivanov@proxmox.com> References: <20211115205043.23286-1-s.ivanov@proxmox.com> From: Thomas Lamprecht <t.lamprecht@proxmox.com> In-Reply-To: <20211115205043.23286-1-s.ivanov@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.115 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [anyevent.pm] Subject: [pve-devel] applied: [PATCH http-server] fix #3724: disable TLS renegotiation X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Tue, 16 Nov 2021 06:35:29 -0000 On 15.11.21 21:50, Stoiko Ivanov wrote: > The issue is probably not critical and best addressed by not running > the perl API servers in an exposed environment or when this needs to > be done by installing a reverse proxy in front of them. > > The DOS potential of the perl daemons is limited more by the limited > number of parallel workers (and the memory constraints of starting > more of them), than by the CPU cycles wasted on TLS renegotiation. > > Still disabling TLS renegotiation should show very little downside: > * it was removed in TLS 1.3 for security reasons > * it was the way nginx addressed this issue [1]. > * we do not use client certificate authentication > > Tested by running `openssl s_client -no_tls1_3 -connect 192.0.2.1:8006` > and issuing a `HEAD / HTTP/1.1\nR\n` > with and without the patch. > > [1] 70bd187c4c386d82d6e4d180e0db84f361d1be02 at > https://github.com/nginx/nginx (although that code adapted to > the various changes in openssl API over the years) > Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com> > --- > src/PVE/APIServer/AnyEvent.pm | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > applied, thanks!