From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 237946D36D for ; Thu, 1 Apr 2021 02:16:29 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1208D1522F for ; Thu, 1 Apr 2021 02:16:29 +0200 (CEST) Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id E590615224 for ; Thu, 1 Apr 2021 02:16:27 +0200 (CEST) Received: by mail-wm1-x32c.google.com with SMTP id n11-20020a05600c4f8bb029010e5cf86347so3156371wmq.1 for ; Wed, 31 Mar 2021 17:16:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=odiso-com.20150623.gappssmtp.com; s=20150623; h=message-id:subject:from:to:date:in-reply-to:references:user-agent :mime-version:content-transfer-encoding; bh=XnkdKK7zQJvrkY34Xdn61x35CXlYPqtTnqsMl+B2334=; b=W99RLFRGifypmj/UFIksS3ngs3b9pgIMXPEONg18AifM4dN2wFObEJs5m7zSvhO7vC H2B+r45IvTC3QxtMQcCIWTB/YXS+GkxCa0rSXEnsbYpu66dK7i/LdKlQHMdG1rW9jKA3 FOG/YXpQYb0Ads2O1py5VDVJ4VSSuS117xyzEsIO5u5OgBl3vKMdCKWQadKYx0VkFsNf K31vtBIaqvZeCC2Bum0CL/soBJ0KRN/wdSmMnNHFYkeUc5tLIouBTRrlA2zR97oLjqA6 f3UuH9OR4HxiNfLo88ClxcNzPGykTF5qe/cBkKcw+WgZmDt2F9lxpSXrdXGlXiJT7yuC 2p/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=XnkdKK7zQJvrkY34Xdn61x35CXlYPqtTnqsMl+B2334=; b=s7I7ODsHvmkoQC8Wu0J9T1puACwyzZf+gQ5BVijq5xAsho8/Tt3h3gmO6Hd8EYkgci nNcY9UT0YwiokPFPBbg5UzTSxo9cm3XaOokSoCrekTzgYiVKMvDhGnSJUkuaR2gYwr3B pPxSyIaZsI86fDGT8bo2gBxtm+y+ZnJHgdoK4ngoI1yAKXWKSQjG80f/81hhOaYpV9FR W0OhonRt200FNLzLwKaD61X9My7sKzPI7+YtwxBFpFqk1qpOvGvQWFhXJ43mRUB6h5d7 oKGlGuwBlrE1LuLxwTd539H/Kg1b//mK7XThyGYtRo+wnG2+uP0W+/87RDlY7Q0B/MH9 K7pw== X-Gm-Message-State: AOAM530tGeqWhGbopuZQP8VymYiiVNP0ilCPAsh4CxDmN1wGYdZf4hqy pTe7ctGExuVjoKHr3QYJ011A31rtTbBfgmXdtmo= X-Google-Smtp-Source: ABdhPJy/IqF3mgcP8zasYrHJ2MlusKO7KtpgJY6a6TViK6lCxcEPPx0gEIh09wc3IK9zW+Q0zD0eCw== X-Received: by 2002:a7b:c188:: with SMTP id y8mr5267057wmi.76.1617236187528; Wed, 31 Mar 2021 17:16:27 -0700 (PDT) Received: from ?IPv6:2a0a:1580:0:1::100c? (ovpn1.odiso.net. [2a0a:1580:2000::3f]) by smtp.gmail.com with ESMTPSA id n9sm6851509wrx.46.2021.03.31.17.16.26 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 31 Mar 2021 17:16:27 -0700 (PDT) Message-ID: From: aderumier@odiso.com To: Proxmox VE development discussion Date: Thu, 01 Apr 2021 02:16:25 +0200 In-Reply-To: <7e6302d05f4098b24891a1fc29e4654de51e47d5.camel@odiso.com> References: <20210328151203.2063706-1-aderumier@odiso.com> <20210328151203.2063706-5-aderumier@odiso.com> <7e6302d05f4098b24891a1fc29e4654de51e47d5.camel@odiso.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.4 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.095 Adjusted score from AWL reputation of From: address DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature RCVD_IN_DNSWL_NONE -0.0001 Sender listed at https://www.dnswl.org/, no trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH qemu-server 4/6] api2: add cloudinit config api X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Apr 2021 00:16:29 -0000 Le mercredi 31 mars 2021 à 19:32 +0200, aderumier@odiso.com a écrit : > hi, > > > Why do you add the macaddress here? I couldn't find anything in > > this > > nor  > > in the previous patch series explaining why this is done. > > This is mostly to show to user that config drive need to be > regenereted. and also, if user delete the nic, but not ipconfig, the diff display the missing mac, so ipconfig is pending, even if user try to regenerate the drive. (Currently, if we delete the iface, the ipconfig is not displayed anymore in gui,  but value is still in vm config file)