From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 72FF91FF0B2 for ; Fri, 25 Sep 2026 12:20:27 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 05B8F2168B; Fri, 25 Sep 2026 12:20:27 +0200 (CEST) Message-ID: Date: Fri, 25 Sep 2026 12:20:23 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH proxmox-backup v3 0/3] fix #6990: server: drop verify state on push & pull job To: Jakob Klocker , pbs-devel@lists.proxmox.com References: <20260922131110.313302-1-j.klocker@proxmox.com> Content-Language: en-US, de-DE From: Christian Ebner In-Reply-To: <20260922131110.313302-1-j.klocker@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1790331623983 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.624 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: RA3RIUBQ6NDRKJ5XSNZE3JAFFXFWCIUD X-Message-ID-Hash: RA3RIUBQ6NDRKJ5XSNZE3JAFFXFWCIUD X-MailFrom: c.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 9/22/26 3:11 PM, Jakob Klocker wrote: > When syncing a snapshot to another datastore, the source's verify_state > is currently carried over to the target. This reports the target > snapshot as verified even though its stored copy was never checked > there. Since verify jobs skip snapshots that already carry a > verify_state, the target's copy can't be verified again. > > Chunks are checksummed in memory while being transferred, but a verify > serves a different purpose: confirming the write to the (external) > target actually succeeded. > > This series stops the target from inheriting the source's > verify_state, so the target is verified independently. On pull, a > verify_state the target obtained on its own is preserved; on push the > state is dropped unconditionally. It also moves the blocking calls in > the touched code paths off the runtime's worker threads onto the > blocking thread pool. > > Tested (verify_state correctly stripped on target): > * Pull, verified source, new content, clean sync > * Pull, verified source, existing content, clean sync > * Pull, corrupted target, resync-corrupt > * Push, verified source (has no corrupt path) > * Pull, independently-verified target, clean re-sync - state preserved Could not find any issues apart the mentioned comments and notes left on individual patches. With those addressed, consider: Reviewed-by: Christian Ebner Tested-by: Christian Ebner