From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40])
	by lore.proxmox.com (Postfix) with ESMTPS id DD1FF1FF0A3
	for <inbox@lore.proxmox.com>; Thu, 01 Oct 2026 14:16:43 +0200 (CEST)
Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1])
	by gate001.proxmox.com (Proxmox) with ESMTP id 93E4E216AF;
	Thu, 01 Oct 2026 14:16:42 +0200 (CEST)
Message-ID: <a760d6d3-8d90-4db5-8ec2-5df70f961359@proxmox.com>
Date: Thu, 1 Oct 2026 14:16:37 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH guest-common v6 09/18] guest id: optionally enforce the
 next-id range and uniqueness
From: Fiona Ebner <f.ebner@proxmox.com>
To: =?UTF-8?Q?Michael_K=C3=B6ppl?= <m.koeppl@proxmox.com>,
 pve-devel@lists.proxmox.com
References: <20260924161510.847362-1-m.koeppl@proxmox.com>
 <20260924161510.847362-10-m.koeppl@proxmox.com>
 <2d268ca0-7544-4fb3-9c8f-f1eabc1ee25d@proxmox.com>
 <d661e700-5b90-45c7-87e6-6fc4308c3957@proxmox.com>
Content-Language: en-US
In-Reply-To: <d661e700-5b90-45c7-87e6-6fc4308c3957@proxmox.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2
X-Bm-Transport-Timestamp: 1790856997739
X-SPAM-LEVEL: Spam detection results:  0
	AWL                     0.484 Adjusted score from AWL reputation of From:
 address
	DMARC_MISSING             0.1 Missing DMARC policy
	KAM_DMARC_STATUS         0.01 Test Rule for DKIM or SPF Failure with Strict
 Alignment (newer systems)
	RCVD_IN_DNSWL_MED        -2.3 Sender listed at https://www.dnswl.org/,
 medium trust
	SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
	SPF_PASS               -0.001 SPF: sender matches SPF record
Message-ID-Hash: 5HVXKSNPBJI3TCRADY5O3CPPHX7Y3P7D
X-Message-ID-Hash: 5HVXKSNPBJI3TCRADY5O3CPPHX7Y3P7D
X-MailFrom: f.ebner@proxmox.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop;
 banned-address; emergency; member-moderation; nonmember-moderation;
 administrivia; implicit-dest; max-recipients; max-size; news-moderation;
 no-subject; digests; suspicious-header
X-Mailman-Version: 3.3.10
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Owner: <mailto:pve-devel-owner@lists.proxmox.com>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Subscribe: <mailto:pve-devel-join@lists.proxmox.com>
List-Unsubscribe: <mailto:pve-devel-leave@lists.proxmox.com>

Am 01.10.26 um 2:07 PM schrieb Fiona Ebner:
> Am 01.10.26 um 2:04 PM schrieb Fiona Ebner:
>> Am 24.09.26 um 6:16 PM schrieb Michael Köppl:
>>> +# Records $id as used. If the next-id datacenter option enforces its
>>> +# range or uniqueness, IDs a new guest must not use are rejected, unless
>>> +# $opts->{existing} marks $id as belonging to an existing guest.
>>> +sub register_used_id($id, $opts = {}) {
>>> +    my $next_id = cfs_read_file('datacenter.cfg')->{'next-id'} // {};
>>
>> Same as above with respect to dying.
> 
> And this is also a wrong comment I forgot to delete before sending, but
> the name could be made $next_id_opts
> 
>>
>>> +    # never reject an existing guest

Sorry, for the noise, but one more suggestion:

# never reject the ID of a currently existing guest

>>> +    my $enforce = $next_id->{enforce} && !$opts->{existing};
>>> +
>>> +    check_range($next_id, $id) if $enforce;
>>> +