From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 4EE861FF13F for ; Thu, 26 Mar 2026 15:44:34 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E816D16CF2; Thu, 26 Mar 2026 15:44:55 +0100 (CET) Message-ID: Date: Thu, 26 Mar 2026 15:44:21 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH proxmox-ve-rs 2/9] frr: implement routemap match/set statements via adjacent tagging To: Stefan Hanreich , pve-devel@lists.proxmox.com References: <20260325094142.174364-1-s.hanreich@proxmox.com> <20260325094142.174364-5-s.hanreich@proxmox.com> Content-Language: en-US From: Hannes Laimer In-Reply-To: <20260325094142.174364-5-s.hanreich@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1774536213328 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.080 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 6APPT7B6YNJBERRWPBPJZUZ3P6OYQSNS X-Message-ID-Hash: 6APPT7B6YNJBERRWPBPJZUZ3P6OYQSNS X-MailFrom: h.laimer@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 2026-03-25 10:41, Stefan Hanreich wrote: > Previously the types used a mix of adjacent / internal tagging and a > nesting of types to represent match and set statements. This has been > simplified by utilizing adjacent tagging on the set / match statements > and using the exact FRR configuration key as the tag. This way a > single enum can be used to represent match / set statements and all > variants can be rendered the same by simply printing the keys / > values. > > This commit also adds a lot of new match / set statements that were > previously not supported. The crate supports now almost all match / > set statements that FRR supports - with only a few having been > omitted. Most notably it is not possible to match on community lists, > support for those is planned in a future patch series. > > Signed-off-by: Stefan Hanreich > --- [..] > diff --git a/proxmox-frr/src/ser/route_map.rs b/proxmox-frr/src/ser/route_map.rs > index d12ae05..22807f1 100644 > --- a/proxmox-frr/src/ser/route_map.rs > +++ b/proxmox-frr/src/ser/route_map.rs > @@ -1,6 +1,11 @@ > +use core::net::{Ipv4Addr, Ipv6Addr}; > use std::net::IpAddr; > > use proxmox_network_types::ip_address::Cidr; > +use proxmox_sdn_types::{ > + bgp::{EvpnRouteType, SetMetricValue, SetTagValue}, > + IntegerWithSign, Vni, > +}; > use serde::{Deserialize, Serialize}; > > /// The action for a [`AccessListRule`]. > @@ -45,6 +50,12 @@ impl AccessListName { > } > } > > +impl PrefixListName { > + pub fn new(name: String) -> PrefixListName { > + PrefixListName(name) > + } > +} the same `impl` block already exists 10 lines above this one :) [..]