From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 37BC81FF139 for ; Tue, 10 Feb 2026 15:36:57 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2341151AD; Tue, 10 Feb 2026 15:37:39 +0100 (CET) Message-ID: Date: Tue, 10 Feb 2026 15:37:04 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH qemu-server v3 3/3] tests: cfg2cmd: add some architecture tests To: Dominik Csapak , pve-devel@lists.proxmox.com References: <20260205141959.3615131-1-d.csapak@proxmox.com> <20260205141959.3615131-4-d.csapak@proxmox.com> <478bffe2-9695-4b96-81c2-d073924cfacf@proxmox.com> <679aa1d2-5a75-4254-b5f8-05a405cfb99b@proxmox.com> Content-Language: en-US From: Fiona Ebner In-Reply-To: <679aa1d2-5a75-4254-b5f8-05a405cfb99b@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1770734139920 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.015 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: VPMYMUG5LFQHPHII3Y4L4HG77ZFBQF6H X-Message-ID-Hash: VPMYMUG5LFQHPHII3Y4L4HG77ZFBQF6H X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Am 10.02.26 um 3:32 PM schrieb Dominik Csapak: > On 2/10/26 2:20 PM, Fiona Ebner wrote: >> Am 05.02.26 um 3:19 PM schrieb Dominik Csapak: >>> one for manually setting >>>    arch: aarch64 >>> >>> in the config for an 'x86_64' host architecture, and one where >>> we don't have 'arch' set in the config on an aarch64 host. >>> >>> Signed-off-by: Dominik Csapak >> >> Note that this makes pve-edk2-firmware-aarch64 a build-dependency. >> Should either be explicitly added in d/control or avoided. > > why is that? the tests themselves don't need to access the actual files, > or do they? Currently they do, in PVE::QemuServer::OVMF, get_ovmf_files() and afterwards when getting the size. Could be mocked of course.