From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <t.lamprecht@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 82E0485A77 for <pve-devel@lists.proxmox.com>; Mon, 20 Dec 2021 20:55:13 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 80F8C21CC1 for <pve-devel@lists.proxmox.com>; Mon, 20 Dec 2021 20:55:13 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 25DA621CB2 for <pve-devel@lists.proxmox.com>; Mon, 20 Dec 2021 20:55:13 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id F104B451C1 for <pve-devel@lists.proxmox.com>; Mon, 20 Dec 2021 20:55:12 +0100 (CET) Message-ID: <a0e2be83-1a96-25fb-e4f0-29f0a0728e3a@proxmox.com> Date: Mon, 20 Dec 2021 20:55:11 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:96.0) Gecko/20100101 Thunderbird/96.0 Content-Language: en-GB From: Thomas Lamprecht <t.lamprecht@proxmox.com> To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>, Dominik Csapak <d.csapak@proxmox.com> Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com> References: <20211220113757.3150847-1-d.csapak@proxmox.com> <0dbe51b8-a128-6ffb-fb1f-85ea055f64ff@proxmox.com> In-Reply-To: <0dbe51b8-a128-6ffb-fb1f-85ea055f64ff@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 1.869 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -3.608 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] applied: [PATCH pve_flutter_frontend] workaround for novnc fullscreen behaviour X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Mon, 20 Dec 2021 19:55:13 -0000 On 20/12/2021 20:19, Thomas Lamprecht wrote: > On 20/12/2021 12:37, Dominik Csapak wrote: >> since the webview seemingly does not allow javascripts 'requestFullscreen', >> workaround that by making the whole webview fullscreen and hiding novncs >> fullscreen button >> >> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com> >> --- >> lib/widgets/pve_console_menu_widget.dart | 14 ++++++-------- >> 1 file changed, 6 insertions(+), 8 deletions(-) >> >> > > applied, thanks! argh, send above out for the wrong patch, this is not yet applied..