From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: Re: [pve-devel] applied: [PATCH pve_flutter_frontend] workaround for novnc fullscreen behaviour
Date: Mon, 20 Dec 2021 20:55:11 +0100 [thread overview]
Message-ID: <a0e2be83-1a96-25fb-e4f0-29f0a0728e3a@proxmox.com> (raw)
In-Reply-To: <0dbe51b8-a128-6ffb-fb1f-85ea055f64ff@proxmox.com>
On 20/12/2021 20:19, Thomas Lamprecht wrote:
> On 20/12/2021 12:37, Dominik Csapak wrote:
>> since the webview seemingly does not allow javascripts 'requestFullscreen',
>> workaround that by making the whole webview fullscreen and hiding novncs
>> fullscreen button
>>
>> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
>> ---
>> lib/widgets/pve_console_menu_widget.dart | 14 ++++++--------
>> 1 file changed, 6 insertions(+), 8 deletions(-)
>>
>>
>
> applied, thanks!
argh, send above out for the wrong patch, this is not yet applied..
prev parent reply other threads:[~2021-12-20 19:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-20 11:37 [pve-devel] " Dominik Csapak
2021-12-20 13:57 ` Aaron Lauterer
2021-12-20 19:55 ` Thomas Lamprecht
2021-12-21 8:06 ` Aaron Lauterer
2021-12-20 19:19 ` [pve-devel] applied: " Thomas Lamprecht
2021-12-20 19:55 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a0e2be83-1a96-25fb-e4f0-29f0a0728e3a@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal