From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <a.lauterer@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 2FBA68B936 for <pve-devel@lists.proxmox.com>; Tue, 25 Oct 2022 10:37:05 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 04CA721502 for <pve-devel@lists.proxmox.com>; Tue, 25 Oct 2022 10:36:35 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for <pve-devel@lists.proxmox.com>; Tue, 25 Oct 2022 10:36:34 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 2D5B744BD9 for <pve-devel@lists.proxmox.com>; Tue, 25 Oct 2022 10:36:34 +0200 (CEST) Message-ID: <a0b0f0a7-affe-276e-967a-eb223c1c80af@proxmox.com> Date: Tue, 25 Oct 2022 10:36:33 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>, Stefan Sterz <s.sterz@proxmox.com> References: <20221025081046.93094-1-s.sterz@proxmox.com> Content-Language: en-US From: Aaron Lauterer <a.lauterer@proxmox.com> In-Reply-To: <20221025081046.93094-1-s.sterz@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.044 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [pools.pm] Subject: Re: [pve-devel] [PATCH manager v4 1/2] api: ceph: add applications of each pool to the lspools endpoint X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Tue, 25 Oct 2022 08:37:05 -0000 works well and now also hides the ceph fs pools, further reducing the chances to build weird constellations :) for the series: Tested-By: Aaron Lauterer <a.lauterer@proxmox.com> On 10/25/22 10:10, Stefan Sterz wrote: > since ceph luminous (ceph 12) pools need to be associated with at > least one applicaton. expose this information here too so that clients > of this endpoint can use it. > > Signed-off-by: Stefan Sterz <s.sterz@proxmox.com> > --- > v3: add an api viewer entry for the applications object. > v4: re-use the 'osd dump' command's result instead of issueing another > command. > > thanks @ alwin antreich for pointing out that pools have applications! > > PVE/API2/Ceph/Pools.pm | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/PVE/API2/Ceph/Pools.pm b/PVE/API2/Ceph/Pools.pm > index 6c05250e..fce56787 100644 > --- a/PVE/API2/Ceph/Pools.pm > +++ b/PVE/API2/Ceph/Pools.pm > @@ -125,6 +125,11 @@ __PACKAGE__->register_method ({ > title => 'Autoscale Status', > optional => 1, > }, > + application_metadata => { > + type => 'object', > + title => 'Associated Applications', > + optional => 1, > + }, > }, > }, > links => [ { rel => 'child', href => "{pool_name}" } ], > @@ -162,6 +167,7 @@ __PACKAGE__->register_method ({ > 'pg_num', > 'crush_rule', > 'pg_autoscale_mode', > + 'application_metadata', > ]; > > # pg_autoscaler module is not enabled in Nautilus