From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <s.ivanov@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by lists.proxmox.com (Postfix) with ESMTPS id BAB8EC2453
 for <pmg-devel@lists.proxmox.com>; Mon, 22 Jan 2024 18:49:56 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
 by firstgate.proxmox.com (Proxmox) with ESMTP id 9B5BE1E51F
 for <pmg-devel@lists.proxmox.com>; Mon, 22 Jan 2024 18:49:26 +0100 (CET)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
 [94.136.29.106])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by firstgate.proxmox.com (Proxmox) with ESMTPS
 for <pmg-devel@lists.proxmox.com>; Mon, 22 Jan 2024 18:49:25 +0100 (CET)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
 by proxmox-new.maurer-it.com (Proxmox) with ESMTP id CF20146216
 for <pmg-devel@lists.proxmox.com>; Mon, 22 Jan 2024 18:49:24 +0100 (CET)
Date: Mon, 22 Jan 2024 18:49:17 +0100
From: Stoiko Ivanov <s.ivanov@proxmox.com>
To: Alexander Zeidler <a.zeidler@proxmox.com>
Cc: pmg-devel@lists.proxmox.com
Message-ID: <Za6qiLLdlUdvsRiy@rosa.proxmox.com>
References: <20231103135456.120601-1-a.zeidler@proxmox.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231103135456.120601-1-a.zeidler@proxmox.com>
X-SPAM-LEVEL: Spam detection results:  0
 AWL -0.313 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_ASCII_DIVIDERS 0.8 Email that uses ascii formatting dividers and possible
 spam tricks
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
 T_SCC_BODY_TEXT_LINE    -0.01 -
 URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See
 http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more
 information. [proxmox.com]
Subject: [pmg-devel] applied: [PATCH pmg-docs 1/2] installation: rephrase
 section "Other Repository Sources"
X-BeenThere: pmg-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Mail Gateway development discussion
 <pmg-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pmg-devel>, 
 <mailto:pmg-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pmg-devel/>
List-Post: <mailto:pmg-devel@lists.proxmox.com>
List-Help: <mailto:pmg-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel>, 
 <mailto:pmg-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Mon, 22 Jan 2024 17:49:56 -0000

Thanks for getting the docs in better shape - much appreciated!
I applied 1/2 - have a question/nit/suggestion for 2/2

On Fri, Nov 03, 2023 at 02:54:55PM +0100, Alexander Zeidler wrote:
> to be Debian release independent & conform to additional repo sections
> 
> Signed-off-by: Alexander Zeidler <a.zeidler@proxmox.com>
> ---
>  pmg-installation.adoc | 12 ++++--------
>  1 file changed, 4 insertions(+), 8 deletions(-)
> 
> diff --git a/pmg-installation.adoc b/pmg-installation.adoc
> index 2860177..1a0bb59 100644
> --- a/pmg-installation.adoc
> +++ b/pmg-installation.adoc
> @@ -433,8 +433,8 @@ or the `md5sum` CLI tool:
>  ----
>  
>  
> -Other Repository Sources
> -~~~~~~~~~~~~~~~~~~~~~~~~
> +Debian Non-Free Repository
> +~~~~~~~~~~~~~~~~~~~~~~~~~~
>  
>  Certain software cannot be made available in the `main` and `contrib`
>  areas of the {debian} archives, since it does not adhere to the Debian
> @@ -447,12 +447,8 @@ are needed in order to support the RAR archive format:
>  
>  * `libclamunrar` for detecting viruses in RAR archives.
>  
> -.Additional sources.list entry for `non-free`
> -----
> -deb http://deb.debian.org/debian/ bookworm non-free
> -deb http://security.debian.org/debian-security bookworm-security non-free
> -deb http://deb.debian.org/debian/ bookworm-updates non-free
> -----
> +To enable the `non-free` component, run `editor /etc/apt/sources.list` and
> +append `non-free` to the end of each `.debian.org` repository line.
>  
>  Following this, you can install the required packages with:
>  
> -- 
> 2.39.2
> 
> 
> 
> _______________________________________________
> pmg-devel mailing list
> pmg-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel
> 
>