From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 80A7F1FF0AF for ; Fri, 20 Nov 2026 14:37:53 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id F22862173A; Fri, 20 Nov 2026 14:37:51 +0100 (CET) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 20 Nov 2026 14:37:46 +0100 Message-Id: Subject: Re: [PATCH pve-manager v2 11/19] ui: form: crs options: make fine-tuning options advanced From: "Daniel Kral" To: "Dominik Rusovac" , X-Mailer: aerc 0.22.0-45-gc30c872fde7b-dirty References: <20261112094437.1951271-1-d.rusovac@proxmox.com> <20261112094437.1951271-12-d.rusovac@proxmox.com> In-Reply-To: <20261112094437.1951271-12-d.rusovac@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1795181866899 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.426 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: Q6ETQQSWHVMOQUW5732AJDDNPG64FZLT X-Message-ID-Hash: Q6ETQQSWHVMOQUW5732AJDDNPG64FZLT X-MailFrom: d.kral@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu Nov 12, 2026 at 10:44 AM CET, Dominik Rusovac wrote: > the CRS settings window has become rather crowded since the addition of > the automatic rebalancing options > > show the hold duration and the minimum imbalance improvement only as > advanced options, as they fine-tune the automatic rebalancing > > Signed-off-by: Dominik Rusovac > --- > > Notes: > changes since v1: > * reword commit > * make weights advanced options in the patch adding them > > www/manager6/form/CRSOptions.js | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/www/manager6/form/CRSOptions.js b/www/manager6/form/CRSOptio= ns.js > index 84f6d506..05c5e222 100644 > --- a/www/manager6/form/CRSOptions.js > +++ b/www/manager6/form/CRSOptions.js > @@ -103,6 +103,8 @@ Ext.define('PVE.form.CRSOptions', { > disabled: '{autoRebalancingDisabled}', > }, > }, > + ], > + advancedItems: [ I'm not so sure about putting the hold duration and margin in the advanced section, if the imbalance threshold and the method stay in the main window... I'd prefer to move them all in the advanced section or only the new weights. > { > xtype: 'numberfield', > name: 'ha-auto-rebalance-hold-duration',