From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id F23741FF0DE for ; Thu, 19 Nov 2026 13:52:33 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id BF47B216A9; Thu, 19 Nov 2026 13:52:33 +0100 (CET) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 19 Nov 2026 13:52:20 +0100 Message-Id: To: "Daniel Kral" , Subject: Re: [PATCH proxmox v2 05/19] resource-scheduling: scheduler: make imbalance with candidate public From: "Dominik Rusovac" X-Mailer: aerc 0.20.0 References: <20261112094437.1951271-1-d.rusovac@proxmox.com> <20261112094437.1951271-6-d.rusovac@proxmox.com> In-Reply-To: X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1795092740426 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.024 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: DA3UHP4KVOW6CLZESMSS5A4V3Y7ZYC37 X-Message-ID-Hash: DA3UHP4KVOW6CLZESMSS5A4V3Y7ZYC37 X-MailFrom: d.rusovac@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu Nov 19, 2026 at 1:41 PM CET, Daniel Kral wrote: > On Thu Nov 12, 2026 at 10:44 AM CET, Dominik Rusovac wrote: >> this is made public, so callers like pve-rs bindings can compute load >> imbalance with migration candidates > > maybe also note here that this is because of backwards compatibility > that is done in pve-rs, because imbalance has been calculated without > the hardcoded 1:5 there, but now that value would also be weighted with > the weights applied > ack, thx for the review! >> >> Signed-off-by: Dominik Rusovac >> --- >> >> Notes: >> no changes since v1, new >> =20 >> ultimately, required to avoid mismatch in imbalance comparison in ol= der >> HA manager versions >> >> proxmox-resource-scheduling/src/scheduler.rs | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/proxmox-resource-scheduling/src/scheduler.rs b/proxmox-reso= urce-scheduling/src/scheduler.rs >> index d6508c15..a9390357 100644 >> --- a/proxmox-resource-scheduling/src/scheduler.rs >> +++ b/proxmox-resource-scheduling/src/scheduler.rs >> @@ -227,7 +227,7 @@ impl Scheduler { >> /// Returns the load imbalance among the nodes as if a specific res= ource was moved. >> /// >> /// See [`calculate_node_imbalance`] for more information. >> - fn node_imbalance_with_migration_candidate(&self, candidate: &Migra= tionCandidate) -> f64 { >> + pub fn node_imbalance_with_migration_candidate(&self, candidate: &M= igrationCandidate) -> f64 { >> calculate_node_imbalance(&self.nodes, |node| { >> node_stats_after_migration(candidate, node).load() >> })