From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 202D71FF0DE for ; Thu, 19 Nov 2026 13:28:08 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 68C65216F0; Thu, 19 Nov 2026 13:28:06 +0100 (CET) Content-Type: text/plain; charset=UTF-8 Date: Thu, 19 Nov 2026 13:28:03 +0100 Message-Id: From: "Daniel Kral" To: "Dominik Rusovac" , Subject: Re: [PATCH proxmox v2 03/19] resource-scheduling: scheduler: abstract post-migration stats logic Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Mailer: aerc 0.22.0-45-gc30c872fde7b-dirty References: <20261112094437.1951271-1-d.rusovac@proxmox.com> <20261112094437.1951271-4-d.rusovac@proxmox.com> In-Reply-To: <20261112094437.1951271-4-d.rusovac@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1795091283859 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.443 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: WPURTVLNXNNNNYRQPQ4DQP7LTVIUNXF5 X-Message-ID-Hash: WPURTVLNXNNNNYRQPQ4DQP7LTVIUNXF5 X-MailFrom: d.kral@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu Nov 12, 2026 at 10:44 AM CET, Dominik Rusovac wrote: > DRY and hide repeatedly used closure inside reusable function > > Reviewed-by: Daniel Kral > Signed-off-by: Dominik Rusovac The Git trailers should be ordered causally, so you Signed-off-by first and then the Reviews/Tests/etc. follow. Patch LGTM, nice refactoring! Anyway: Reviewed-by: Daniel Kral