From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 824F01FF0DF for ; Thu, 19 Nov 2026 07:37:00 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 74BA621681; Thu, 19 Nov 2026 07:36:58 +0100 (CET) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 19 Nov 2026 07:36:52 +0100 Message-Id: Subject: Re: applied: [PATCH guest-common/manager/qemu-server v7 0/3] fix #5032: add guest time sync via QGA From: "Jakob Klocker" To: "Thomas Lamprecht" , X-Mailer: aerc 0.20.0 References: <20261117123932.995999-1-j.klocker@proxmox.com> <179501161066.1321919.3320586608164988877.b4-ty@b4> In-Reply-To: <179501161066.1321919.3320586608164988877.b4-ty@b4> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1795070212892 X-SPAM-LEVEL: Spam detection results: 0 AWL 1.188 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: XL2R45KJAOZFDLGD77BPKSDPH3Y7QWUV X-Message-ID-Hash: XL2R45KJAOZFDLGD77BPKSDPH3Y7QWUV X-MailFrom: j.klocker@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed Nov 18, 2026 at 3:22 PM CET, Thomas Lamprecht wrote: >> [snip] > > Applied, thanks! > > I adapted a few things while/on applying, mainly: > > - ui: the agent editor now loads a value of 'yes' or 'on' for the new > option as checked. Before, it showed such a value as unchecked, so > saving any other agent setting dropped the option. > - qemu-server: reworded the FIXME about enabling the option by default > and dropped its version number, like the other major version markers. > - guest-common, qemu-server: wrapped two calls with their arguments as > one block, as proxmox-perltidy keeps that form. > > On top, I added a qemu-server commit with tests for which setting > decides the sync after a rollback with RAM and for > should_sync_time_on_resume(): > > tests: cover the guest time sync decision, also for snapshot rollback > https://git.proxmox.com/?p=3Dqemu-server.git;a=3Dcommitdiff;h=3D7cf9da5= 9d92f31c7eb00b97dcb17cfa0d7e0c2b6 > > Two things are still missing and could be nice as follow-ups: > > - the agent section of the admin guide (qm.adoc) does not document the > new option yet. > - the Yew agent editor in proxmox-yew-comp, as used by the mobile UI and > PDM, drops the option on save, as pve-api-types does not know it yet. > That needs a regeneration of pve-api-types and a checkbox there. > Thanks for the improvements. I'll add the follow-ups to my backlog.