From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id E3B981FF0C0 for ; Wed, 18 Nov 2026 16:20:59 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id A3378216DF; Wed, 18 Nov 2026 16:20:57 +0100 (CET) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 18 Nov 2026 16:20:53 +0100 Message-Id: Subject: Re: [PATCH ha-manager v4 03/17] tree-wide: remove unused return values at parse_sid callsites From: =?utf-8?q?Michael_K=C3=B6ppl?= To: "Daniel Kral" , X-Mailer: aerc 0.22.0 References: <20261118144502.231134-1-d.kral@proxmox.com> <20261118144502.231134-4-d.kral@proxmox.com> In-Reply-To: <20261118144502.231134-4-d.kral@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1795015253958 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.184 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: WJNTWQBYUBQ6NSGMKNQ6E3XVJJVLLCUI X-Message-ID-Hash: WJNTWQBYUBQ6NSGMKNQ6E3XVJJVLLCUI X-MailFrom: m.koeppl@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed Nov 18, 2026 at 3:44 PM CET, Daniel Kral wrote: [snip] > @@ -361,7 +361,7 @@ __PACKAGE__->register_method({ > code =3D> sub { > my ($param) =3D @_; > > - my ($sid, $type, $vmid) =3D PVE::HA::Config::parse_sid(extract_p= aram($param, 'sid')); > + my ($sid) =3D PVE::HA::Config::parse_sid(extract_param($param, '= sid')); > my $purge =3D extract_param($param, 'purge') // 1; > > if (!PVE::HA::Config::service_is_configured($sid)) { > @@ -461,7 +461,7 @@ __PACKAGE__->register_method({ > > my $result =3D {}; > > - my ($sid, $type, $vmid) =3D PVE::HA::Config::parse_sid(extract_p= aram($param, 'sid')); > + my ($sid) =3D PVE::HA::Config::parse_sid(extract_param($param, '= sid')); $type isn't unused here after the rebase (see if below) > my $req_node =3D extract_param($param, 'node'); > my $resource_type =3D extract_param($param, 'resource-type'); > if ($resource_type ne $type) { > @@ -585,7 +585,7 @@ __PACKAGE__->register_method({ > > my $result =3D {}; > > - my ($sid, $type, $vmid) =3D PVE::HA::Config::parse_sid(extract_p= aram($param, 'sid')); > + my ($sid) =3D PVE::HA::Config::parse_sid(extract_param($param, '= sid')); [snip]