From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id C13301FF0C0 for ; Wed, 18 Nov 2026 12:17:55 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id C4CA521743; Wed, 18 Nov 2026 12:17:53 +0100 (CET) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 18 Nov 2026 12:17:44 +0100 Message-Id: Subject: Re: [PATCH qemu-server-rs v4 1/4] cpu: add pve-qemu-server-cpu crate for vCPU binding From: "Elias Huhsovitz" To: "Fiona Ebner" , "Thomas Lamprecht" , "Dominik Csapak" , X-Mailer: aerc 0.20.0 References: <20261111152027.260117-1-e.huhsovitz@proxmox.com> <20261111152027.260117-2-e.huhsovitz@proxmox.com> <4f5ed842-1699-45d6-895b-e5fb664bd195@proxmox.com> <7d82cab7-5941-42cf-a610-02e8cdb12bda@proxmox.com> <28a30f3c-f9bb-4d24-8150-a8d35ca81f30@proxmox.com> In-Reply-To: <28a30f3c-f9bb-4d24-8150-a8d35ca81f30@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1795000665059 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.414 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: RMTOOX7TFQTU6SJ7J7FEG2AENUG7BQPR X-Message-ID-Hash: RMTOOX7TFQTU6SJ7J7FEG2AENUG7BQPR X-MailFrom: e.huhsovitz@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Wolfgang Bumiller X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Thank you for the discussion! On Wed Nov 18, 2026 at 11:14 AM CET, Fiona Ebner wrote: > Am 18.11.26 um 9:32 AM schrieb Thomas Lamprecht: >> Am 18.11.26 um 08:48 schrieb Dominik Csapak: >>> On 11/17/26 6:20 PM, Thomas Lamprecht wrote: >>>> Am 11.11.26 um 16:22 schrieb Elias Huhsovitz: >>>>> "pve-qemu-server-pci" >>>>> ] >>>> >>>> applies to yours and Dominiks [pci series]: I'd rather not propagate >>>> the naming oddity of including "server" here to rust, when we finally >>>> got a chance of dropping some legacy decisions cheaply. >>>> I.e., lets do at least a s/server// please, server does made really >>>> sense in how "qemu-server" gets used nowadays. >>> >>> sure of course, i just started with something and didn't get feedback >>> on the naming (until now) so that's fine by me >>> >>> (i feared 'pve-qemu-rs' is too close to 'pve-qemu-kvm' or 'pve-qemu', >>> but if it's fine for you i'll change it) >>=20 >> FWIW, pve-vm is fine too for me. But here I'd appreciate some input >> from the people working most in this subsystems. >>=20 >>>> And another thing that would be easy to do now: put these into the >>>> qemu-server repo directly and generate a perlmod backed library >>>> there. Each change, addition would then avoid going through an >>>> extra repo and packaging, and qemu management is a big, important >>>> and well enough scoped use case to justify a dedicated lib here (which >>>> I'd not do for all repos). >>> >>> sure, started fresh to not run into merge conflicts and basically >>> starting from a clean slate regarding build system >>> (which made my life easier). I'll send a new version of my >>> series integrating it into qemu-server repo >>=20 >> I'd not rush this to quickly now (just to avoid needless work), as >> mentioned already initially, maintainers should have a say here and >> asking them directly on such core naming is more fruitful than hoping >> it gets noticed when seeing a series fly by on the list. >>=20 > > I agree having it in the qemu-server repo directly would be nice. Noted, this just leaves me with one question, I would like to have answered before continuing with the new version: What is the concensus on "rust vs perl" for this code? I originally chose rust, because: * Type system * Better data structures * Directly calling sched_setaffinity(2) so we don't have go use the taskset wrapper. * Potential future optimizations where a low-level language might come in handy. * v1/v2 was written in perl, but it quickly became very convoluted IMHO. (But I think I can design it in a more straightforward way this time around) But I do acknowledge the downsides. Since, you are the Maintainers, I would love to hear your opinion :) > > I feel like pve-qemu-rs might be fine. Rust crates for the management > layer for pve-qemu(-kvm), so in that sense, closely related. Or > pve-qemu-manager(-rs)? Or what is the concrete worry with the name being > too similar? > > With pve-vm, the danger is that we add a second VM guest type at some > point in the future, which is not related to QEMU. Then we might be > tempted to put it into the same crate/workspace or have a confusing > name, which might not be ideal. But I guess we could manage, so would > also be fine by me. > > For Dominik's PCI series, the interface looks good to me. It's not too > invasive to the current code, while also allowing to move more parts of > config generation there in the future. Some parts like machine version > checking/hardware config, could be better separated, as they are not > specific to PCI.