all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: "Daniel Kral" <d.kral@proxmox.com>
To: "Dominik Rusovac" <d.rusovac@proxmox.com>, <pve-devel@lists.proxmox.com>
Cc: Thomas Skinner <thomas@atskinner.net>
Subject: Re: [PATCH pve-manager v4 1/4] api: nodes: add endpoint to set maintenance mode
Date: Tue, 17 Nov 2026 10:21:56 +0100	[thread overview]
Message-ID: <DMXDJHVJY3RX.2W60XCEFCZTHN@proxmox.com> (raw)
In-Reply-To: <DMXD1JFBRH9F.30YAJLEG0F0HE@proxmox.com>

On Tue Nov 17, 2026 at 9:58 AM CET, Dominik Rusovac wrote:
> thx for the review, will send a v5
>
> On Mon Nov 16, 2026 at 12:57 PM CET, Daniel Kral wrote:
>> On Fri Nov 13, 2026 at 4:26 PM CET, Dominik Rusovac wrote:
>>
>> A PVE::Tools::run_command() would be enough here AFAICT, because if it
>> fails then we just fail here as well and forward the error message.
>>
>
> I will write a dedicated wrapper that queues a request to enable/disable
> maintenance 

Hm, run_command() might be a better separation here.

If a wrapper would be called here directly, then essentially pvedaemon
would write to HA state, but if the ha-manager CLI is run here then just
HA-specific code writes to the HA state.

No hard feelings though, would just like to minimize the HA stack's API
surface to read-only helpers for external packages while letting any
writes go through API/CLI paths from the HA stack directly.




  reply	other threads:[~2026-11-17  9:22 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-13 15:26 [PATCH-SERIES docs/ha-manager/manager v4 0/4] fix #6144: add api and ui for node maintenance mode Dominik Rusovac
2026-11-13 15:26 ` [PATCH pve-manager v4 1/4] api: nodes: add endpoint to set " Dominik Rusovac
2026-11-16 11:57   ` Daniel Kral
2026-11-17  8:58     ` Dominik Rusovac
2026-11-17  9:21       ` Daniel Kral [this message]
2026-11-17  9:40         ` Dominik Rusovac
2026-11-13 15:26 ` [PATCH pve-manager v4 2/4] fix #6144: ui: ha: status: allow toggling " Dominik Rusovac
2026-11-17  9:07   ` Daniel Kral
2026-11-17 11:02     ` Dominik Rusovac
2026-11-13 15:26 ` [PATCH pve-ha-manager v4 3/4] api: status: report node maintenance request for lrm entries Dominik Rusovac
2026-11-16 12:02   ` Daniel Kral
2026-11-13 15:26 ` [PATCH pve-docs v4 4/4] ha-manager: maintenance mode: mention web ui menu Dominik Rusovac
2026-11-19 10:05 ` [PATCH-SERIES docs/ha-manager/manager v4 0/4] fix #6144: add api and ui for node maintenance mode Dominik Rusovac

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DMXDJHVJY3RX.2W60XCEFCZTHN@proxmox.com \
    --to=d.kral@proxmox.com \
    --cc=d.rusovac@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=thomas@atskinner.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal