From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id AB7511FF0BC for ; Mon, 16 Nov 2026 15:38:32 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 56C7B216F8; Mon, 16 Nov 2026 15:38:32 +0100 (CET) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 16 Nov 2026 15:38:27 +0100 Message-Id: To: "Christian Ebner" , Subject: Re: [PATCH proxmox-backup 8/9] docs: add explanation regarding ``rebuild-chunk-markers`` option From: "Shan Shaji" X-Mailer: aerc 0.20.0 References: <20261019160359.20851-1-s.shaji@proxmox.com> <20261019160359.20851-9-s.shaji@proxmox.com> <861386f3-a00b-4b62-92da-840afe32bb29@proxmox.com> In-Reply-To: <861386f3-a00b-4b62-92da-840afe32bb29@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1794839907755 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.348 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: BWMGN5LOF6245PPVDUPBTG6RKXJHCTSG X-Message-ID-Hash: BWMGN5LOF6245PPVDUPBTG6RKXJHCTSG X-MailFrom: s.shaji@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed Nov 11, 2026 at 4:04 PM CET, Christian Ebner wrote: > One comment in-line. > > On 10/19/26 6:04 PM, Shan Shaji wrote: >> Signed-off-by: Shan Shaji >> --- >> docs/storage.rst | 7 +++++-- >> 1 file changed, 5 insertions(+), 2 deletions(-) >> >> diff --git a/docs/storage.rst b/docs/storage.rst >> index 2c6ba0a85..811b5ff44 100644 >> --- a/docs/storage.rst >> +++ b/docs/storage.rst >> @@ -312,8 +312,11 @@ To setup a new datastore called ``my-s3-store`` pla= ced in a bucket called ``pbs- >> A datastore cannot be shared between multiple Proxmox Backup Server in= stances, only one instance can >> operate on the datastore at a time. However, datastore contents used o= n an instance which is no >> longer available can be reused on a fresh installation. To recreate th= e datastore, you must pass the >> -``reuse-datastore`` and ``overwrite-in-use`` flags. Since the datastore= name is used as prefix, the >> -same datastore name must be used. > > comment: this deleted the important requirement that the same datastore > name must be used. > Thanks for catching that. I will fix it in v2. >> +``reuse-datastore`` and ``overwrite-in-use`` flags. The optional ``rebu= ild-chunk-markers`` flag, >> +disabled by default, creates local zero-byte chunk markers when reusing= an S3 datastore. These markers >> +allow Proxmox Backup Server to identify chunks already stored in S3 whe= n they are not present in >> +the in-memory cache, avoiding unnecessary uploads. The time required to= create these markers depends >> +on the number of chunks. >> >> .. code-block:: console >>