From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 495871FF0BC for ; Mon, 16 Nov 2026 11:32:46 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 948F021703; Mon, 16 Nov 2026 11:32:42 +0100 (CET) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 16 Nov 2026 11:32:37 +0100 Message-Id: To: "Daniel Kral" , Subject: Re: [PATCH ha-manager v2 12/16] lrm: update the service status once per work iteration From: =?utf-8?q?Michael_K=C3=B6ppl?= X-Mailer: aerc 0.22.0 References: <20261112163113.294302-3-d.kral@proxmox.com> <20261112163113.294302-15-d.kral@proxmox.com> In-Reply-To: <20261112163113.294302-15-d.kral@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1794825158075 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.186 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 6NUJJ6K2FKSPKDV472KKMVAC7JP4D5KI X-Message-ID-Hash: 6NUJJ6K2FKSPKDV472KKMVAC7JP4D5KI X-MailFrom: m.koeppl@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu Nov 12, 2026 at 5:31 PM CET, Daniel Kral wrote: [snip] > diff --git a/src/PVE/HA/LRM.pm b/src/PVE/HA/LRM.pm > index 7ae239ec..a68ab008 100644 > --- a/src/PVE/HA/LRM.pm > +++ b/src/PVE/HA/LRM.pm > @@ -385,7 +385,7 @@ sub work { > my $status =3D $self->get_local_status(); > my $state =3D $status->{state}; > > - $self->update_lrm_status(); > + my $status_update_successful =3D $self->update_lrm_status(); > > my $fence_request =3D $self->is_fence_requested(); > > @@ -516,7 +516,7 @@ sub work { > > # if we could not get the current service status there's no = point > # in doing anything, try again next round. > - return if !$self->update_lrm_status(); > + return if !$status_update_successful; > > if ($self->{shutdown_request}) { > > @@ -615,7 +615,7 @@ sub work { > } elsif ($state eq 'maintenance') { > > my $startime =3D $haenv->get_time(); > - return if !$self->update_lrm_status(); > + return if !$status_update_successful; I noticed that in the 'active' branch, this happens inside an eval, resulting in a `return 1` from the `work()` function, whereas here it would `return undef`. Is there a reason for this? Because just from reading through the `work()` function and where it's used (haven't tried this yet) it seems like this would stop the LRM entirely? On the master this would happen if the second call of `update_lrm_status()` failed for some reason. Here, I think the following could happen: # pmxcfs is temporarily unavailable, so this is undef my $status_update_successful =3D $self->update_lrm_status(); # pmxcfs is up again within 5s (the max wait time for getting the # lock) # this works now get_protected_ha_agent_lock(); ... # in maintenance branch return if !$status_update_successful; # returns due to stale status This doesn't introduce the problem, but widens then window for it, no? I'll try to test this as well. I don't think this is very likely to occur (considering pmxcfs has to be unwritable and then writable again within a ~5s window), but it could also easily be avoided, unless I'm missing something about why there's no eval in for the maintenance block? > > # wait until all active services moved away > my $service_count =3D $self->active_service_count(); > diff --git a/src/test/test-cfs-unavailable1/log.expect b/src/test/test-cf= s-unavailable1/log.expect > index a9bb10f2..4d796c50 100644 > --- a/src/test/test-cfs-unavailable1/log.expect > +++ b/src/test/test-cfs-unavailable1/log.expect > @@ -36,27 +36,22 @@ info 120 cmdlist: execute service vm:101 stop= ped > err 120 node1/crm: could not read manager status: cfs connection = refused - not mounted? > err 120 node1/crm: got unexpected error - cfs connection refused = - not mounted? > err 121 node1/lrm: updating service status from manager failed: c= fs connection refused - not mounted? > -err 121 node1/lrm: updating service status from manager failed: c= fs connection refused - not mounted? > err 121 node1/lrm: unable to write lrm status file - cfs connecti= on refused - not mounted? > err 140 node1/crm: could not read manager status: cfs connection = refused - not mounted? > err 140 node1/crm: got unexpected error - cfs connection refused = - not mounted? > err 141 node1/lrm: updating service status from manager failed: c= fs connection refused - not mounted? [snip]