From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 79E981FF0B7 for ; Fri, 13 Nov 2026 19:14:56 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 327D521229; Fri, 13 Nov 2026 19:14:55 +0100 (CET) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 13 Nov 2026 19:14:49 +0100 Message-Id: To: "Thomas Lamprecht" , From: "Max R. Carrara" Subject: Re: [PATCH common,qemu-server,network,manager 0/10] mark secrets in schemas and redact them from the system report X-Mailer: aerc 0.18.2-0-ge037c095a049 References: <20261101213835.353604-1-t.lamprecht@proxmox.com> In-Reply-To: <20261101213835.353604-1-t.lamprecht@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1794593689320 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.303 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: RDPUEXKAMBXYD4HP2YQ2SNDVDDKNC3Z3 X-Message-ID-Hash: RDPUEXKAMBXYD4HP2YQ2SNDVDDKNC3Z3 X-MailFrom: m.carrara@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Sun Nov 1, 2026 at 10:34 PM CET, Thomas Lamprecht wrote: > The system report only requires Sys.Audit, but contains all guest configs > and the SDN configs verbatim. So it includes cloud-init passwords, in pla= in > text for Windows guests, and the API tokens of SDN IPAM and DNS > integrations. A report is often sent to support by someone who does not > own these credentials, for example a hosting provider renting out VMs. > > This series adds a 'sensitive' flag for schema properties and uses it to > redact the report [...] Haven't found anything off. The only sus thing is that `git am -3` fumbles applying patch #7; the conflict is trivial to fix. Did some basic smoke-testing; the `pvereport` on my dev machine doesn't look any different than before, since there are no sensitive properties declared anywhere. For storage, we'd have to deprecate the `sensitive-properties` key in `plugindata()` together with `::Plugin::sensitive_properties()` at some point, because these properties are currently not taken into account. When slapping a new property for testing purposes into the SSHFS plugin and marking it as sensitive like the series describes, the property does get redacted as expected in `pvereport`. Neat. As mentioned above, if I remove `sensitive =3D> 1` and add it to the `sensitive-properties` key in `plugindata()`, it obviously does not get redacted. This is painfully obvious from the diffs, but wanted to check this again explicitly anyway. LGTM. Consider: Reviewed-by: Max R. Carrara Tested-by: Max R. Carrara