From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id A1D031FF0B7 for ; Fri, 13 Nov 2026 14:22:28 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 8381D216D1; Fri, 13 Nov 2026 14:22:24 +0100 (CET) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 13 Nov 2026 14:22:20 +0100 Message-Id: From: =?utf-8?q?Michael_K=C3=B6ppl?= To: "Fiona Ebner" , =?utf-8?q?Michael_K=C3=B6ppl?= , Subject: Re: [PATCH qemu-server v7 10/32] migrate: call prepare_local_cluster_checks() method X-Mailer: aerc 0.22.0 References: <20261112115001.107306-1-f.ebner@proxmox.com> <20261112115001.107306-11-f.ebner@proxmox.com> <3f5e77a9-b9fc-4b51-b9ee-4829f6801eb1@proxmox.com> In-Reply-To: <3f5e77a9-b9fc-4b51-b9ee-4829f6801eb1@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1794576140675 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.186 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: XQ6LJAVGAL62Q6BDYSVHZ5XDM3W6TQYB X-Message-ID-Hash: XQ6LJAVGAL62Q6BDYSVHZ5XDM3W6TQYB X-MailFrom: m.koeppl@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri Nov 13, 2026 at 2:09 PM CET, Fiona Ebner wrote: [snip] >>> diff --git a/src/PVE/QemuMigrate.pm b/src/PVE/QemuMigrate.pm >>> index 30bb98f7..f9002002 100644 >>> --- a/src/PVE/QemuMigrate.pm >>> +++ b/src/PVE/QemuMigrate.pm >>> @@ -356,10 +356,7 @@ sub prepare { >>> print "websocket tunnel started\n"; >>> $self->{tunnel} =3D $tunnel; >>> } else { >>> - # test ssh connection >>> - my $cmd =3D [@{ $self->{rem_ssh} }, '/bin/true']; >>> - eval { $self->cmd_quiet($cmd); }; >>> - die "Can't connect to destination address using public key\n" = if $@; >>> + $self->prepare_local_cluster_checks(); >> >> Without the changes to QemuMigrateMock.pm from the following commit, >> building qemu-server fails at this commit, assuming pve-guest-common >> already has patch 03 and 04 applied. I suppose that's only a problem >> when bisecting, but wanted to note it nonetheless. > > Technically yes, but it does not fit semantically. This goes together > with guest-common patch 03. The change in the next commit goes together > with guest-common patch 04. I guess technically, two dependency bumps > right after each other would be needed ^^ Or it could be avoided with > squashing this into the next patch and stating the switchover is done > together for bisectability. Not sure if it's worth it though. Yeah, I also don't like the idea of squashing these. I mostly brought it up because I'm not sure how we usually handle such cases or how problematic it is. Although I suppose this doesn't happen too often. > >> >>> } >>> >>> return $running; >> >>