From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 87C441FF0B7 for ; Fri, 13 Nov 2026 13:51:15 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 2DB9121754; Fri, 13 Nov 2026 13:51:03 +0100 (CET) Content-Type: text/plain; charset=UTF-8 Date: Fri, 13 Nov 2026 13:50:56 +0100 Message-Id: From: =?utf-8?q?Michael_K=C3=B6ppl?= To: "Fiona Ebner" , Subject: Re: [PATCH container v7 17/32] migrate: call prepare_local_cluster_checks() method Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Mailer: aerc 0.22.0 References: <20261112115001.107306-1-f.ebner@proxmox.com> <20261112115001.107306-18-f.ebner@proxmox.com> In-Reply-To: <20261112115001.107306-18-f.ebner@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1794574256336 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.190 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: WPJLIP4LFKR2TY5WJ42EHD4OSEYBKGKA X-Message-ID-Hash: WPJLIP4LFKR2TY5WJ42EHD4OSEYBKGKA X-MailFrom: m.koeppl@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Reviewed-by: Michael K=C3=B6ppl On Thu Nov 12, 2026 at 12:48 PM CET, Fiona Ebner wrote: > Factoring out the common SSH check and in preparation for checking > that the configuration can be parsed on the target. > > Signed-off-by: Fiona Ebner > --- > > Dependency bump for guest-common needed! > > New in v7. > > src/PVE/LXC/Migrate.pm | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/src/PVE/LXC/Migrate.pm b/src/PVE/LXC/Migrate.pm > index 04133f4..f7a4ec0 100644 > --- a/src/PVE/LXC/Migrate.pm > +++ b/src/PVE/LXC/Migrate.pm > @@ -167,10 +167,7 @@ sub prepare { > $self->log('info', "websocket tunnel started\n"); > $self->{tunnel} =3D $tunnel; > } else { > - # test ssh connection > - my $cmd =3D [@{ $self->{rem_ssh} }, '/bin/true']; > - eval { $self->cmd_quiet($cmd); }; > - die "Can't connect to destination address using public key\n" if= $@; > + $self->prepare_local_cluster_checks(); > } > > # in restart mode, we shutdown the container before migrating