From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 644141FF0B7 for ; Fri, 13 Nov 2026 13:50:15 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id CED9E21747; Fri, 13 Nov 2026 13:50:11 +0100 (CET) Content-Type: text/plain; charset=UTF-8 Date: Fri, 13 Nov 2026 13:50:07 +0100 Message-Id: Subject: Re: [PATCH qemu-server v7 12/32] api: ha migrate: delete with-conntrack-state for offline migration From: =?utf-8?q?Michael_K=C3=B6ppl?= To: "Fiona Ebner" , Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 X-Mailer: aerc 0.22.0 References: <20261112115001.107306-1-f.ebner@proxmox.com> <20261112115001.107306-13-f.ebner@proxmox.com> In-Reply-To: <20261112115001.107306-13-f.ebner@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1794574207737 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.192 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: GLMQ3G3SGGQHT5ZBZBBSCI72HAHWXTKU X-Message-ID-Hash: GLMQ3G3SGGQHT5ZBZBBSCI72HAHWXTKU X-MailFrom: m.koeppl@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Reviewed-by: Michael K=C3=B6ppl On Thu Nov 12, 2026 at 12:48 PM CET, Fiona Ebner wrote: > For a HA migration, if the 'with-conntrack-state' property is > explicitly set to 0, it is passed along as a migration option through > the HA stack. But it's not needed and increases the noise in the log, > so drop it instead. > > Reported-by: Daniel Kral > Reported-by: Michael K=C3=B6ppl > Signed-off-by: Fiona Ebner > --- > > New in v7. > > src/PVE/API2/Qemu.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/PVE/API2/Qemu.pm b/src/PVE/API2/Qemu.pm > index 6a6f15b2..f31ede9f 100644 > --- a/src/PVE/API2/Qemu.pm > +++ b/src/PVE/API2/Qemu.pm > @@ -5689,7 +5689,7 @@ __PACKAGE__->register_method({ > } else { > warn "VM isn't running. Doing offline migration instead.\n" = if $param->{online}; > $param->{online} =3D 0; > - $param->{'with-conntrack-state'} =3D 0; > + delete $param->{'with-conntrack-state'}; > } > > my $storecfg =3D PVE::Storage::config();